Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420504

Summary:	AbstractParent#getChildNodes should return an immutable copy, IParent should offer removeChildNodes operation.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF FX	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.wienand
Version:	3.9.0
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Alexander Nyßen

2013-10-28 09:56:05 EDT

Up to now, children can be added to a parent via addChildNodes() or via getChildNodes().add(), where the second version will lead to an illegal state (children are not properly added to their parent. Furthermore, there is no removeChildNodes() operation. 

We should either make the list of children observable (then we can remove the addChildNodes() operation), or we should ensure getChildNodes() returns an immutable list, adding a dedicated removeChildNodes() operation in addition.

Comment 1 Alexander Nyßen

2013-10-30 08:03:05 EDT

Added a removeChildNodes operation and ensured getChildNodes returns an immutable list. Renamed addChildNodes to addChildren and removeChildNodes to removeChildren, and renamed getChildNodes to getChildrenUnmodifiable.

Comment 2 Alexander Nyßen

2014-03-04 15:24:30 EST

As we have removed the related code base from SwtFX, this is no longer an  issue.

Comment 3 Alexander Nyßen

2014-08-11 16:29:27 EDT

Change component to FX, as SwtFX is succeeded by FX.UI.