Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420484

Summary:	[TextSizeDetermination] Text height is bigger in IE9/10 than Firefox/Chrome/Opera
Product:	[RT] RAP	Reporter:	Ivan Furnadjiev <ivan>
Component:	RWT	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	rsternberg
Version:	unspecified
Target Milestone:	2.2 M3
Hardware:	PC
OS:	Windows 7
Whiteboard:	sr212

Description Ivan Furnadjiev

2013-10-28 06:57:51 EDT

Text size measurement produces 1px higher size in IE9/10. This leads to 1px visual offset from the vertical text alignment, noticeable mainly in Tree. In method FontSizeCalculation.js#_measureElement we do "ceil" on the text height. As a result, text height measured in IE9/10 as 17.01 is rounded to 18. We should use "round" instead of "ceil" in text height measuring. I don't think that this will lead to any regression (test cut-off).

Comment 1 Ivan Furnadjiev

2013-10-28 07:10:55 EDT

Fixed in master with commit 372d5f3361f5348d8fa6ced8bd009b2ba17d6406.

Comment 2 Ralf Sternberg

2014-01-27 07:56:35 EST

I think the fix is safe, since it only affects the height, not the width. So we won't get into any trouble with line breaks and cut-offs. +1 for 2.1.2.

Comment 3 Ivan Furnadjiev

2014-01-29 12:44:21 EST

Backported to 2.1-maintenance branch with change https://git.eclipse.org/r/21243