Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420370

Summary:

Tooltips and command popups are closed on click on the popup

Product:

[ECD] Orion

Reporter:

Malgorzata Janczarska <malgorzata.tomczyk>

Component:

Client

Assignee:

Malgorzata Janczarska <malgorzata.tomczyk>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

maciej.bendkowski, simon_kaegi, Szymon.Brandys

Version:

4.0

Flags:

simon_kaegi: review+

Target Milestone:

4.0 RC3

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Fix for excluded nodes	none

Description Malgorzata Janczarska

2013-10-25 07:57:20 EDT

Every tooltip in Orion including the command parameter popup gets closed when user clicks on it. Unfortunately when this is a parameter popup (like Add Tag on Git Log or Edit configuration ently on Git repository page) user usually wants to click on the text field to input the parameter, but this closes the popup, so parameter cannot be typed.

Comment 1 Malgorzata Janczarska

2013-10-25 08:05:16 EDT

Created attachment 236888 [details]
Fix for excluded nodes

When debugging I discovered that every popup comes with a list of "excluded nodes". Clicking on one of those excluded nodes should not close this popup. But in code we are checking if the click came from *every* excluded nodes instead of just *some* (any) of them. Popups typically come with a list of two excluded nodes, and of cause we click at only one at a time. The attached patch fixes the problem.

Comment 2 Malgorzata Janczarska

2013-10-25 08:13:28 EDT

Maciek also discovered that because of this bug we can't use "Copy to" and "Move to" command in the navigator, because click on one of those should open a submenu, but it closed the whole menu instead.

Comment 3 Simon Kaegi

2013-10-25 12:10:03 EDT

Gosia reviewed and I pushed a slight alteration of Gosia's patch.

The goal is to avoid a second dismiss call when all excludeNodes are not present.

As part of the discussion for this patch we're fairly confident that the code is leaking dismiss functions in the tooltip