| Summary: | Editor page is called Coding, should be Editor | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Anthony Hunter <ahunter.eclipse> |
| Component: | Editor | Assignee: | Anthony Hunter <ahunter.eclipse> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | john.arthorne, mamacdon, Silenio_Quarti, simon_kaegi |
| Version: | 4.0 | Flags: | simon_kaegi:
review+
Silenio_Quarti: review+ |
| Target Milestone: | 4.0 RC3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Anthony Hunter
Change for review is at: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=ah-Bug420302&id=5f8a70b880913914203921ff3fc4c8af6c3c7df3 Changes look fine to fine. Should we update the User Guide as well? There is a section called "Coding Page". (In reply to Silenio Quarti from comment #2) > Changes look fine to fine. Should we update the User Guide as well? There is > a section called "Coding Page". Hi John, assuming we want to push this into 4.0 given the editor is the main page, we also want to rename the page un the User Guide. Simon has oked. The fix is pushed to master at: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=7708657aa51216cd9853440ecdbf501bc8f6b4e3 Shouldn't this be "Editor", not "Editing"? All our other pages are named after things, not actions. Also the page is called "Editor" in the hamburger links. (In reply to Mark Macdonald from comment #5) > Shouldn't this be "Editor", not "Editing"? All our other pages are named > after things, not actions. Also the page is called "Editor" in the hamburger > links. Agreed, I just followed from "Coding", it is now Editor, same as the other pages. Fixed with commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=b65486f5e6d3c54d6d0d7898e97519ae34988bbc (In reply to Silenio Quarti from comment #2) > Changes look fine to fine. Should we update the User Guide as well? There is > a section called "Coding Page". User Guide has been updated as well. |