Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420298

Summary: Git repository page: "show in navigator" action should be renamed.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: GitAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, mamacdon
Version: 4.0Flags: mamacdon: review+
ken_walker: review+
Target Milestone: 4.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed fix patch none

Description libing wang CLA 2013-10-24 11:52:46 EDT 
In git repository page, one of the the actions on a repository still says "show in navigator".
When I click on it it brings me to the editor page.
We should think about re-wording it.
Comment 1 libing wang CLA 2013-10-24 12:05:49 EDT 
Will change it to "Show in editor".
Will also try to find out if there are other places using "Navigator".
Comment 2 libing wang CLA 2013-10-24 15:03:24 EDT 
Created attachment 236857 [details]
Proposed fix patch
Comment 3 Mark Macdonald CLA 2013-10-24 16:23:38 EDT 
Since we are changing the message keys here, I would prefer to shorten them -- eg. change them to "ShowInEditor" and "ShowInEditorTooltip" rather than the long strings they are now.

Everything else looks fine.
Comment 4 Ken Walker CLA 2013-10-24 16:41:22 EDT 
looks good and what Mark said as well
Comment 5 libing wang CLA 2013-10-24 16:57:18 EDT 
(In reply to Mark Macdonald from comment #3)
> Since we are changing the message keys here, I would prefer to shorten them
> -- eg. change them to "ShowInEditor" and "ShowInEditorTooltip" rather than
> the long strings they are now.
> 
> Everything else looks fine.

Good point. Will do when push.