Bugzilla – Full Text Bug Listing
| Summary: | Delete 'sourceTemplatePlugin' folders | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> |
| Component: | Releng | Assignee: | Platform-Releng-Inbox <platform-releng-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P2 | CC: | david_williams, Lars.Vogel |
| Version: | 3.6 | ||
| Target Milestone: | 4.4 M6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Dani Megert
I don't think "the last week" is the right time to make this change, in a milestone. We should do it right after M4 declared. I'm not even sure how to "confirm" all is ok, once we make the change? Should also confirm these are in no way related to the "get source with that?" p2 metadata (_might_ have been related, in past, in PDE build, even if not now?). From a grep search, it appears these are the projects that have 'sourceTemplatePlugin' folders. ./eclipse.platform.team/features/org.eclipse.cvs-feature/sourceTemplatePlugin ./eclipse.jdt/org.eclipse.jdt-feature/sourceTemplatePlugin ./eclipse.platform.releng/features/org.eclipse.rcp/sourceTemplatePlugin ./eclipse.platform.releng/features/org.eclipse.platform-feature/sourceTemplatePlugin ./eclipse.platform.releng/features/org.eclipse.sdk.examples-feature/sourceTemplatePlugin ./eclipse.pde/org.eclipse.pde-feature/sourceTemplatePlugin (In reply to David Williams from comment #1) > I'm not even sure how to "confirm" all is ok, once we make the change? Verify that the source features and plug-ins are correct. Probably should not do this during last week of a milestone ... so will try and remember to do early in M6. removed the 5 in 'eclipse.platform.releng' repository. http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=d520b762e60780599a0c355ce224a240a8faed6e Whoops, re-reading ... I see this was about 'sourceTemplatePlugin' ... I removed 'sourceTemplateFeature'. Will revert. (In reply to David Williams from comment #4) > Will revert. Reverted with c811c4045d06f736e7fe41d5343b4813179a013e http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=c811c4045d06f736e7fe41d5343b4813179a013e reverted the 3 in 'eclipse.platform.releng': http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=6661e48a0145ff03ba0bb9ce148ef6973aeb9085 This leaves 3 others, in projects I couldn't commit to: ./eclipse.platform.team/features/org.eclipse.cvs-feature/sourceTemplatePlugin ./eclipse.jdt/org.eclipse.jdt-feature/sourceTemplatePlugin ./eclipse.pde/org.eclipse.pde-feature/sourceTemplatePlugin We can try a nightly, just to make sure nothing breaks ... then so the remaining 3? I'm assuming we'd no longer need the sourceTemplateFragment either? I see three of them, only in 'eclipse.platform.releng': $ find . -type d -name sourceTemplateFragment ./eclipse.platform.releng/features/org.eclipse.rcp/sourceTemplateFragment ./eclipse.platform.releng/features/org.eclipse.platform-feature/sourceTemplateFragment ./eclipse.platform.releng/features/org.eclipse.sdk.examples-feature/sourceTemplateFragment (In reply to David Williams from comment #7) > I'm assuming we'd no longer need the > > sourceTemplateFragment > > either? Can say out of my head - would have to dig into this a bit deeper to say yes or no. (In reply to Dani Megert from comment #8) > (In reply to David Williams from comment #7) > > I'm assuming we'd no longer need the > > > > sourceTemplateFragment > > > > either? > > Can say out of my head - would have to dig into this a bit deeper to say yes > or no. * Can't* I did confirm in this morning's N build repository there were the exact same number of bundles (and features) as in the previous N build repository ... so I take that as confirmation that it is safe to remove the sourceTemplatePlugin directories. Removed remaining folders with: http://git.eclipse.org/c/jdt/eclipse.jdt.git/commit/?id=7d09f1439ab8f49c8aa1799753214cb7b91430d6 http://git.eclipse.org/c/pde/eclipse.pde.git/commit/?id=94cff084cf5215291850550b48db3eeb17e966f9 http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=93967100b2110b9ad807bd3ccc7493db944f1917 |