Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420001

Summary: Crawler search: Search model accumulates duplicated results when doing incremental rendering.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi
Version: 4.0Flags: simon_kaegi: review+
Target Milestone: 4.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed fix. none

Description libing wang CLA 2013-10-21 12:24:08 EDT
To reproduce:
1. In html5 file system, create a  sub folder and create file under the folder.
2. type some keywords in the file and save.
3. Select the folder and do a scope search.
4. In the search page type the keyword and search.

You will find there are two duplicated files in the results.

The reason is that the searchModel.buildResultModel function is not clearing the root list. This is OK if there is no incremental rendering, which is used by crawler to show progress.
Comment 1 libing wang CLA 2013-10-21 12:27:08 EDT
Created attachment 236728 [details]
Proposed fix.

This did not happen before. Might be a regression due to the recent changes.
Comment 2 Simon Kaegi CLA 2013-10-21 12:30:44 EDT
My kind of rc3 fix -- +1