Bugzilla – Full Text Bug Listing
| Summary: | [IE only] cannot stage changes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> | ||||
| Component: | Git | Assignee: | Simon Kaegi <simon_kaegi> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | critical | ||||||
| Priority: | P3 | CC: | ken_walker, malgorzata.tomczyk, simon_kaegi, Szymon.Brandys | ||||
| Version: | 4.0 | Flags: | simon_kaegi:
review+
|
||||
| Target Milestone: | 4.0 RC3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Joy -- please investigate more deeply. Looks like when there is an empty request data IE passes "undefined" string instead of empty string or null. On the server side we use OrionServlet.readJSONRequest(request) that reads the request data and tries to parse it into json. It is prepared for empty string and null but when it gets "undefined" it throws an exception. I suspect there might be more problems like this, not only in Git. I'm not sure what would be the best way to deal with it now.
Adding if("undefined".equals(resultString)) resultString = ""; in the right place would do the trick, but you didn't hear it from me ;)
Created attachment 236733 [details]
Very bad proposition of the fix
In case you would like to give it a try I'm attaching a patch.
I'd prefer to look at fix client side We need to do -- xhr.send(data || null) (Thanks Grant) This is pretty standard/safe stuff. |
I20131018-2049 - happens in IE10 and IE11 - attempt to stage a change on the Git Status page - it fails with the following error status displayed: "A JSONObject text must begin with '{' at character 1"