Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419973

Summary:

Shell page does not set page target in global commands

Product:

[ECD] Orion

Reporter:

Malgorzata Janczarska <malgorzata.tomczyk>

Component:

Client

Assignee:

Grant Gayed <grant_gayed>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

mamacdon, simon_kaegi, Szymon.Brandys

Version:

4.0

Flags:

simon_kaegi: review+

Target Milestone:

4.0 RC3

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
proposed fix	none

Description Malgorzata Janczarska

2013-10-21 09:35:02 EDT

mGlobalCommands.setPageTarget is called in shellPage but does not contain "target". The "target" attribute should contain the current directory. This way we would have proper related links etc.

Comment 1 Grant Gayed

2013-10-21 16:41:10 EDT

Created attachment 236735 [details]
proposed fix

Comment 2 Malgorzata Janczarska

2013-10-29 12:40:49 EDT

(In reply to comment #1)
> Created attachment 236735 [details]
> proposed fix

I applied this fix and it seems to be fixing the problem. Can you push it to R4.0RC3_maintenance branch?

Comment 3 Grant Gayed

2013-10-29 12:53:25 EDT

Yes, pushed to the R4.0RC3_maintenance branch.

Keeping report open as a reminder to push to master once it re-opens.

Comment 4 Simon Kaegi

2013-10-30 15:45:59 EDT

Fixed in 4.0