Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419858

Summary: Change the wording of the 'Checkout' button tooltip to indicate it affects the current selection
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: GitAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, maciej.bendkowski, mamacdon
Version: unspecified   
Target Milestone: 5.0 M1   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
fix none

Description Michael Rennie CLA 2013-10-18 11:03:11 EDT 
When you are on the Git status page looking at files / changes the 'Checkout' button is confusing:

1. it should probably be 'Revert' or 'Reset' or 'Replace' since thats what it does
2. the tooltip should probably read: 'Revert/Reset/Replace selected files, discarding all changes' instead of 'Checkout files, discarding all changes'. 

As the tooltip is now it implies it will get rid of all of your changes, not that it applies to what is selected.
Comment 1 Maciej Bendkowski CLA 2013-10-18 11:18:14 EDT 
Currently, we use strict git terminology on git pages, in order to facilitate working with git repositories for advanced, or semi-advanced git users. 'Checkout' is a git operation name, which among other things, deletes working changes. We could change it to something more neutral, e. g. 'Undo', however such a rename should be consistent with other operation names. We already had such discussions, e. g. here (bug 413546).

*** This bug has been marked as a duplicate of bug 413546 ***
Comment 2 Michael Rennie CLA 2013-10-18 11:51:57 EDT 
(In reply to Maciej Bendkowski from comment #1)
> Currently, we use strict git terminology on git pages, in order to
> facilitate working with git repositories for advanced, or semi-advanced git
> users. 'Checkout' is a git operation name, which among other things, deletes
> working changes. 

I'm fine with that, and the general wording of commands can be updated across the board in bug 413546. In the meantime, the tool tip needs to be updated to indicate that it works on the current selection.
Comment 3 Michael Rennie CLA 2013-10-18 11:56:56 EDT 
Created attachment 236663 [details]
fix

funnily enough, Git already has an NLS'd string which says the right thing, but is not being used.
Comment 4 Michael Rennie CLA 2013-10-21 12:49:37 EDT 
(In reply to Michael Rennie from comment #3)
> Created attachment 236663 [details]
> fix
> 
> funnily enough, Git already has an NLS'd string which says the right thing,
> but is not being used.

made a pull request for the change to make things easier: https://github.com/eclipse/orion.client/pull/30
Comment 5 Curtis Windatt CLA 2013-10-23 13:47:40 EDT 
I also found the tooltip wording odd.  Comment #1 makes a good argument not to change the button name, but the tooltip the patch uses is more helpful and accurate.
Comment 6 Mark Macdonald CLA 2013-11-04 15:20:43 EST 
Pushed the tooltip improvement:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fe8e522