Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419637

Summary: patch should not be partially applied if failure occurs during processing
Product: [ECD] Orion Reporter: Grant Gayed <grant_gayed>
Component: GitAssignee: Project Inbox <orion.git-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 4.0   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
test patch file none

Description Grant Gayed CLA 2013-10-16 16:44:52 EDT 
I20131016-1157

- check out branch origin/bug419611 of org.eclipse.orion.client from the main repo
- attempt to apply the attached patch, which will fail as a result of bug 419611
- go to the repository's status page and see that there's now 1 file to stage (it was changed as a result of the initial processing of the patch, before the error was encountered)
- a patch should be applied either completely or not at all (or selectively by the user as is possible in Eclipse), but to apply it only partially as a result of having encountered an error is confusing and likely results in mismatched code across files
Comment 1 Grant Gayed CLA 2013-10-16 16:45:16 EDT 
Created attachment 236570 [details]
test patch file
Comment 2 John Arthorne CLA 2015-05-05 16:18:32 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html