Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419530

Summary:	creating git repo with invalid name can make Git Repositories page unusable
Product:	[ECD] Orion	Reporter:	Grant Gayed <grant_gayed>
Component:	Git	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	P3	CC:	ken_walker, malgorzata.tomczyk, Szymon.Brandys
Version:	4.0	Flags:	ken_walker: review+ Szymon.Brandys: review+
Target Milestone:	4.0 RC3
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:

Description Grant Gayed

2013-10-15 17:30:08 EDT

I20131015-1220

- use a workspace that you don't care about

- on the Git Repositories page create a NEW repository (not a clone) with name: https://github.com/Venemo/gnome-shell-extension-weather.git
   -> it appears to create the new repo with the problematic name
- the Git Repositories page will fail to render from now on, and I haven't found a way to fix this state from the client (attempting to delete or rename the bad guy in the editor page's navigation tree fails)
   -> it was also affecting my ability to access other files on the Editor page (eg.- delete/rename/open them), but these cases seem to be working for me again

Comment 1 Grant Gayed

2013-10-16 13:08:57 EDT

Adding CC's, this seems like a candidate for 4.0RC3.  I needed Ken to make direct changes to my workspace on the server to get its Git Repositories page to show again.

Comment 2 Malgorzata Janczarska

2013-10-17 09:19:03 EDT

The clone name validator was not implemented at all. This is an implementation that disallows invalid clone names:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?h=Bug419530&id=efd0f2b3fe940316217f08fadc5ce89371bb790c

Ken, do I have your +1 to push it in RC3?

Comment 3 Ken Walker

2013-10-17 09:22:10 EDT

Can you also get another committer to review. Thanks.

Comment 4 Malgorzata Janczarska

2013-10-18 15:16:53 EDT

Pushed.