Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419376

Summary: NOL selection listener still active when project-nav is opened
Product: [ECD] Orion Reporter: Malgorzata Janczarska <malgorzata.tomczyk>
Component: ClientAssignee: Malgorzata Janczarska <malgorzata.tomczyk>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon, Silenio_Quarti, Szymon.Brandys
Version: 4.0Flags: Szymon.Brandys: review+
Target Milestone: 4.0 RC2   
Hardware: PC   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 418944    

Description Malgorzata Janczarska CLA 2013-10-14 11:29:26 EDT 
The Nav-on-left view's selection listener is still active when the NOL is not displayed (but we display the project-nav). This causes some errors in rendering commands being caught by my debugger and probably breaks the flow of when selection in project-nav changes.
It also probably causes the selection listener being notified more than once each time NOL is re-rendered (because we add the selection listener while rendering the view, but we do not unregister it on destroying the view).
Comment 1 Malgorzata Janczarska CLA 2013-10-14 11:37:21 EDT 
This is the fix that unregisters the selection listener on destroy:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=Bug419376&id=c0e0b67708805a56585fde29828b66c50c96b865
Comment 2 Malgorzata Janczarska CLA 2013-10-14 12:15:45 EDT 
Fixed