Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419295

Summary: Site editor page layout is screwed up
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, libingw, simon_kaegi
Version: 3.0Flags: ken_walker: review+
libingw: review+
Target Milestone: 4.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
SCREENSHOT
none
screenshot, after fix none

Description Mark Macdonald CLA 2013-10-11 18:05:36 EDT
Created attachment 236423 [details]
SCREENSHOT

1. Create site.
2. Click on it to go to the site editor page
3. The table layout is messed up-- some icons are truncated, and there's a lot of unnecessary whitespace in the leftmost column.
Comment 1 Mark Macdonald CLA 2013-10-17 23:13:12 EDT
Created attachment 236633 [details]
screenshot, after fix

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=019ee19

This makes it look better for me. Removed unnecessary wrapper elements and converted some TABLEs to DIVs. This makes the normal section stylesheets apply correctly (perhaps due to different CSS display rules for table elements vs. plain old DIVs?)

The form on top and the "mappings" section below are now the same width. The mappings section can also be collapsed without shrinking to a tiny width like it did before.
Comment 2 Ken Walker CLA 2013-10-18 05:20:20 EDT
Looks good
Comment 3 Mark Macdonald CLA 2013-10-18 13:57:11 EDT
OK , pushed
Comment 4 libing wang CLA 2013-10-18 14:06:06 EDT
Tried the patch, looks good.