Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419240

Summary: CloneJob discards original failure on secondary exception
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: GitAssignee: John Arthorne <john.arthorne>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Szymon.Brandys
Version: 4.0   
Target Milestone: 5.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2013-10-11 11:57:06 EDT
If CloneJob fails to complete the clone operation, it attempts to delete the partial clone to avoid leaving behind a broken repository. However if this deletion fails, we only report the deletion failure and the cause of the original failure is lost. We should just log the secondary failure and return the real reason why cloning failed.

This is making it hard to track down intermittent test failures.
Comment 1 John Arthorne CLA 2013-10-11 12:06:42 EDT
Pushed to gerrit and asked Szymon for review:

https://git.eclipse.org/r/#/c/17308/