Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419234

Summary: Do not use ,navigate command in Git commands
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: GitAssignee: Project Inbox <orion.git-inbox>
Status: RESOLVED FIXED QA Contact: Szymon Brandys <Szymon.Brandys>
Severity: normal    
Priority: P3 CC: maciej.bendkowski
Version: 4.0Flags: maciej.bendkowski: review+
Target Milestone: 4.0 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Szymon Brandys CLA 2013-10-11 11:00:20 EDT

    
Comment 1 Szymon Brandys CLA 2013-10-11 11:07:49 EDT
gitCommands.js lines 2142 - 2148

var templateString = require.toUrl("edit/edit.html") + "#{,resource,params*}"; //$NON-NLS-1$ //$NON-NLS-0$
window.location = new URITemplate(templateString).expand({
resource: "", //$NON-NLS-0$
														params: {
															navigate: repoJson.Children[0].ContentLocation + "?depth=1"
														}
													});
Comment 2 Szymon Brandys CLA 2013-10-11 11:10:18 EDT
The fix is gitCommands.js lines 2142 - 2148

replace

var templateString = require.toUrl("edit/edit.html") + "#{,resource,params*}"; //$NON-NLS-1$ //$NON-NLS-0$
window.location = new URITemplate(templateString).expand({
  resource: "", //$NON-NLS-0$  
  params: {
    navigate: repoJson.Children[0].ContentLocation + "?depth=1
  }
});

with

var editLocation = require.toUrl("edit/edit.html") + "#" + repoJson.Children[0].ContentLocation + "?depth=1"; //$NON-NLS-2$ //$NON-NLS-1$ //$NON-NLS-0$
window.location = editLocation;
Comment 3 Szymon Brandys CLA 2013-10-11 11:22:58 EDT
Fixed.