Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419154

Summary: Global search: Default search page can not recognize current file system as scope.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: 4.0Flags: mamacdon: review+
Target Milestone: 4.0 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 419178    
Attachments:
Description Flags
Patch file
none
Second patch after Mark's first refview none

Description libing wang CLA 2013-10-10 10:53:37 EDT 
The search.html is triggered by the page link plugin so that it does not have the current scope.
If I am in a none-orion file sys, I have to use related links-> scope search.
It is OK but first time user may need some time to get used to it.

I am wondering is there is a way to pass the current scope into the page link plug in. If that is possible then we do not really need the scope search in the related link.
Comment 1 libing wang CLA 2013-10-10 15:50:56 EDT 
Created attachment 236351 [details]
Patch file
Comment 2 libing wang CLA 2013-10-11 10:22:02 EDT 
Created attachment 236375 [details]
Second patch after Mark's first refview
Comment 3 libing wang CLA 2013-10-11 10:28:28 EDT 
Mark, thanks for the review suggestion.
I made the second patch so that the search URL uses an additional parameter to decide if we should use the root location from the resource.

After you + it, I will remove the scope search from related link.
But the action item from the editor page still has the "scope search" when an item is selected.
That says:
1. The "global" search URL always use a "location" when the URL is generated for the page link, with a "useRootLocation=true"
2.The scope search URL is similar but without that useRootLocation param.
Comment 4 Mark Macdonald CLA 2013-10-11 11:03:55 EDT 
This is good, thanks for the update. +