Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 419084

Summary: Orion Build Hudson: orion-server #8 fail
Product: [ECD] Orion Reporter: Anthony Hunter <ahunter.eclipse>
Component: ServerAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: john.arthorne, ken_walker, simon_kaegi, Szymon.Brandys
Version: 4.0Flags: john.arthorne: review+
Target Milestone: 4.0 RC2   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 418655    
Bug Blocks:    

Description Anthony Hunter CLA 2013-10-09 16:50:13 EDT
This build is failing in the JUnit tests, all with the same:

java.lang.NullPointerException
        at org.eclipse.orion.server.tests.AbstractServerTest.createUser(AbstractServerTest.java:75)
        at org.eclipse.orion.server.tests.AbstractServerTest.setUpAuthorization(AbstractServerTest.java:52)

I have debugged the tests running from maven on my Linux machine where I can duplicate the issue and CompatibilityMetaStore is correctly started as the only service.
Comment 1 Szymon Brandys CLA 2013-10-10 04:04:58 EDT
Build against 4.0RC1 (89e2f1395fe5be51143a35a518aa6b4ce2b97328) as well as subsequent commit (510e08f71bd3ab71fa59abb9dadb3b4f14b386f3 from John) is green. The next commit thought (791cb490d2623465494909667bdeed309728595f) which is the fix for "Bug 418621 UserServiceHelper needs help to pick user admin service" breaks the build.
Comment 2 Anthony Hunter CLA 2013-10-10 14:19:40 EDT
A fix for review is attached to commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?h=ah-Bug419084&id=388ff78149b0ecbbf450c0403e84914440c7e825

The JUnit tests do not use the orion.product to start services, it uses a special ServerTestsActivator to start things it needs.
Comment 3 John Arthorne CLA 2013-10-10 15:51:46 EDT
Yes it is not pretty but this is what we have done for other bundles too.
Comment 4 Anthony Hunter CLA 2013-10-10 16:29:56 EDT
(In reply to Anthony Hunter from comment #2)
> A fix for review is attached to commit:
> http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?h=ah-
> Bug419084&id=388ff78149b0ecbbf450c0403e84914440c7e825