Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 418883

Summary:

Image visible while "Save As..." is not enabled after patch for bug 417427

Product:

[Technology] Jubula

Reporter:

Sebastian Struckmann <sebastian.jubula>

Component:

Assignee:

Sebastian Struckmann <sebastian.jubula>

Status:

CLOSED FIXED

QA Contact:

Oliver Goetz <Oliver.Goetz>

Severity:

normal

Priority:

CC:

alexandra.schladebeck, markus.tiede

Version:

unspecified

Keywords:

triaged

Target Milestone:

2.3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch	none
second version of the patch	markus.tiede: iplog+

Description Sebastian Struckmann

2013-10-08 04:18:07 EDT

The patch for bug 417427 together with the patch for bug 373928 causes the image in the image view to be visible while the "Save As..." button for the image is not enabled. We should discuss how this should be handled for the upcoming release.

Comment 1 Alexandra Schladebeck

2013-10-10 06:10:11 EDT

As discussed, for the release 7.2, we are leaving both commits in. We should fix this though, to make using the new feature more comfortable.

Comment 2 Sebastian Struckmann

2013-11-08 08:04:04 EST

Created attachment 237310 [details]
patch

With this patch the "Save Image As..." is enabled if and only if there is an image displayed in the image view.

Comment 3 Markus Tiede

2013-11-08 08:38:49 EST

@SSt: Could you please change the following:
 - if you define getter / setter please make use of them e.g. ImageView line 235
 - alter the implementation from a plain String[] for image description attributes to transient attributes of a custom "Image" instance which encapsulates all necessary image information we need.
 - alter the context id scope to "org.eclipse.jubula.client.ui.contexts.*"
 - move getScreenshotInfo() method / logic from TestResultNode class to TestResultNodeImageProvider class

Comment 4 Sebastian Struckmann

2013-11-08 10:04:14 EST

Created attachment 237311 [details]
second version of the patch

Thanks for the feedback, Markus!

Comment 5 Markus Tiede

2013-11-08 10:51:48 EST

Patch reviewed, adjusted and applied with

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=fd896ac6d169e9fd5d4ec3cf2f88c36d9cb721c2

Comment 6 Oliver Goetz

2013-11-12 03:11:38 EST

Verified. "Save as.." is enabled if an image is displayed even if right before that the view focus has been changed e.g. to properties view as described in bug 417427. Tested in reporting perspective as well as in execution perspective.