Bugzilla – Full Text Bug Listing
| Summary: | New database handler for Gerrit | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Community | Reporter: | Denis Roy <denis.roy> | ||||||||
| Component: | Website | Assignee: | phoenix.ui <phoenix.ui-inbox> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | chris.guindon, david_williams | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Comment on attachment 236188 [details]
Patch v1
Look good to me!
Created attachment 236915 [details]
Patch v2
I typically try to avoid combining changes, but I'm testing locally and ShortOpenTags is off, which is the default on most servers. Since Matt is in the process of building a new www VM, I think we can start actively fixing these.
Chris, please review if you can and I'll push this today.
Not sure how to remove the .settings and such files from being generated in the patch, but I don't be committing those. Created attachment 236958 [details] gitignore_global (In reply to Denis Roy from comment #3) > Not sure how to remove the .settings and such files from being generated in > the patch, but I don't be committing those. You need a global gitignore file. Attach is a copy of my personal global gitignore file. For more information: https://help.github.com/articles/ignoring-files#global-gitignore Let me know once you did a re-roll of your patch and I will review it! thanks I've pushed this through with a gitignore. Sorry, I was working on something else. http://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/?id=53adb9ae40abf5eb77ad28eda00a4993de74a0a1 |
Created attachment 236188 [details] Patch v1 I want to create a simple web api call that will require reading the Gerrit database. I've created the out-of-Git classfile, and this is the proposed change to app.class.php