Bugzilla – Full Text Bug Listing
| Summary: | Sections across Orion should be unified | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> | ||||||||||
| Component: | Client | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | antonm, ken_walker, malgorzata.tomczyk | ||||||||||
| Version: | 4.0 | Flags: | Szymon.Brandys:
review+
|
||||||||||
| Target Milestone: | 4.0 RC2 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Szymon Brandys
Created attachment 236166 [details]
Git Status with Project styles
(In reply to Szymon Brandys from comment #0) > This is probably too late > for 4.0, but I think we should work on that right after 4.0 is announced. To clarify, I think it is too late for unifying the code, but I think Sections on Git, Settings pages and others should look similar to Project's sections. I think this should be done for 4.0. I am not sure who is the right person to work on that. On the second thought I think a better person is Anton. Created attachment 236217 [details]
Git repositories page
Created attachment 236218 [details]
Git repository view
Created attachment 236219 [details]
Settings page with bad section layout
I started to override the section with styles from project view to unify them for our non opensource Orion usage, and it works fine in some cases (see Git repository view), but then I discovered that we have some places where we are using only the section without a title (for instance git repositories page or git log) and this doesn't look fine. Also there are some pages, like attached Settings page, where the section was not used correctly, the contents of the section is in fact below the section and I can't style it changing css. The question is if there is something I can do with those problems only by css changes, without editing orion source code. The questions is if Anton likes the changes and Ken's gives +1 to release that to RC2. If so, we may change that by tweaking CSS + some changes on pages. Another concern that we have and need Anton's comment on it is what to do with pages like Git Repositories or Git Log where there is no section header. So far all elements on the list are just "boxed". +1 for aligning the look - I'd like to try a branch if possible Nice job Gosia. I think this looks more consistent now. The settings page looks a bit wonky - but I think you recognize that, so that would need a bit of attention to lay it out in line with the borders. The repositories page looks more consistent, but I think in the longer term will need a bit of attention too - to make the content style blend a bit better. I think you should push this for Orion. We'll have a UX discussion about it at the next call to gather some feedback from our team. Thanks. (In reply to Anton McConville from comment #10) > I think you should push this for Orion. We'll have a UX discussion about it > at the next call to gather some feedback from our team. I'm not sure if I should commit those changes now. I could probably fix the Settings page, because it's obvious how it should look like, but I would have to leave the blue box for Repositories and Git Log pages and this looks very unprofessionally. This is a commit that contains changes that apply styles to Sections and fixes the problem in Settings: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=Bug418796_Sections&id=98a52820331119399a256750c65404e741bf7757 It should be merged with master when the headless box problem is fixed. I'll make a proposal for the repositories page before Thursday. However, I think this exercise helps highlight that the repositories page already has the problem even as it stands. Committing your update so far improves things in my opinion, and would help us discover other problems more quickly. (In reply to Anton McConville from comment #13) > I'll make a proposal for the repositories page before Thursday. > > However, I think this exercise helps highlight that the repositories page > already has the problem even as it stands. Committing your update so far > improves things in my opinion, and would help us discover other problems > more quickly. Note Anton that we need something that is implementable quickly. Any further improvements will be done (hopefully) during 5.0. BTW I do not think this particular issue highlights any repositories page problems. This page as well as git log or any other page that shows lists is different than pages with lots of sections with headers. So that's why it needs more attention at this moment. Changes pushed to master. Opened Bug 419002 and Bug 419004 for remaining styling decisions to be made. |