Bugzilla – Full Text Bug Listing
| Summary: | Inconsistent icons | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Client | Assignee: | Anton McConville <antonm> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | ken_walker, mamacdon |
| Version: | 3.0 | Flags: | mamacdon:
review+
ken_walker: review+ |
| Target Milestone: | 4.0 RC2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 418680 | ||
|
Description
Mark Macdonald
The blue file icons are a design choice right now. They are treated differently within the navigator as they always have been. We will continue with them as they are for R4.0 at least. Opinion is mixed about them - some people prefer the colour. I plan to use this bug to list the icons that I haven't updated to be vector/flat. There are 2 inconsistencies that I think we need to fix for 4.0:
1) The Delete ("X") icon. It was recently changed to use thicker lines and light grey instead of black, and now looks out of place among the black Git icons.
2) The "core-sprite-file" and "core-sprite-folder" classes have not been updated to blue yet. Their counterparts "core-sprite-file_model" and "core-sprite-folder_model" have been changed to blue. I don't know what the _model distinction is, but they should all be blue.
Personally, I am fine with having blue file & folder icons, and leaving the other icons (Git, etc) as black for 4.0.
Pushed a batch of updated icons to a branch called UpdatedIcons Taking this in two bites. I cut a bunch of icons that I had and checked for color consistency with the shades of grey. Looks much better throughout. The main inconsistencies now are within pockets of git icons. I'll work on those over the weekend if I can - possibly sticking to the ideas we have for them for the most part. Pushed this much. I'll work on some more during the weekend. The intention is to allow feedback on this set of icons. Just to note - I'm pushing what I consider to be an improvement with consistency in look and color for the icons. There are a lot of icons. I want to push what I have available now to offer a few more days of feedback with them. I can do what I can to change them based on feedback before the end of 4.0. I'll add some more, and fix Mark's observations - that the bandaid and pull icons don't have transparent backgrounds. Pushed more icons to UpdatedIconsPart2 (In reply to Anton McConville from comment #7) > Pushed more icons to UpdatedIconsPart2 OK, I've prepared the sprites for all Git icons. However, we're still missing one: > reset.png I've noticed that the git log page has another icon to replace, and a couple that need some colour consistency attention. I'd like to push the second batch that I did today, and then take care of the final ones in a third set. It's a lot to stay on top of - rather than add more in this time I'd like to release the new ones from today, and work on the remaining ones for git log, and for reset. UpdatedIconsPart3 branch looks at remaining icons for Git Log. |