Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 418687

Summary: Nav behaves incorrectly after moving a file in HTML5 nav file system
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Silenio_Quarti, simon_kaegi
Version: 3.0Flags: simon_kaegi: review+
Target Milestone: 4.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
possible patch none

Description Mark Macdonald CLA 2013-10-04 10:37:10 EDT 
(To reproduce this bug, you must be running with a fix for bug 417880, so the left-hand nav can reveal HTML5 local filesystem contents.)

1. Install the HTML5LocalFile plugin
2. Start editing a file from the HTML5 local file system.
3. Use left-hand nav to rename the file you're editing.
4. Expected the editor to reload with the new filename, but instead the editor just goes away.


It looks like the fileCommands are not providing the file's new location to the nav. This probably stems from the command making a bad assumption about the fileClient.moveFile() return value, that just "happens to work" with the default Orion file impl. 

Need to figure out what file services are actually required to return here and then fix fileCommands accordingly.
Comment 1 Silenio Quarti CLA 2013-10-11 14:27:21 EDT 
Created attachment 236413 [details]
possible patch

This patch makes HTML5 file system return the metadata of the item copied/moved.  This is what the orion file system does. I am not sure it was spec behavior or not.

An alternative fix would be to check for null in fileComamnds.js and request the metadata.

Simon, what do you think?
Comment 2 Simon Kaegi CLA 2013-10-18 01:01:59 EDT 
I think go for it for now to get it working. We really need to update our fileservice API at some point and I honestly had hoped the HTML5 FileSystem API would be its basis however it is still in flux.

anyway +1