Bugzilla – Full Text Bug Listing
|
Description
Dani Megert
Dani, that's going to be a *huge* amount of churn so I'm not sure when / how we're going to get there. I'm +1 for 'e4.*' at least since we have a chance there because there's less code and fewer warnings to start with. I am a bit skeptical whether attacking the warnings on the more mature components is worth the time (and the risk of a regression happening). (In reply to Eric Moffatt from comment #1) > Dani, that's going to be a *huge* amount of churn so I'm not sure when / how > we're going to get there. I'm +1 for 'e4.*' at least since we have a chance > there because there's less code and fewer warnings to start with. > > I am a bit skeptical whether attacking the warnings on the more mature > components is worth the time (and the risk of a regression happening). In those cases we have to ignore them - at least in the build, otherwise there is no chance to see and fix "real" warnings. I can do that if you list the projects where you don't intend to get rid of the warnings. Dani, are we talking about pages like: http://download.eclipse.org/eclipse/downloads/drops4/I20131029-2000/compilelogs/plugins/org.eclipse.jface_3.10.0.v20131015-1506/@dot.html PW (In reply to Paul Webster from comment #3) > Dani, are we talking about pages like: > http://download.eclipse.org/eclipse/downloads/drops4/I20131029-2000/ > compilelogs/plugins/org.eclipse.jface_3.10.0.v20131015-1506/@dot.html > > PW What I meant, is, I need the list of those that *you* want to disable ;-). Here you go: I've disabled 'raw' and 'unchecked' for all non-e4 bundles with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5438d8323aa6ff6cc59f5de9f305a490c7392410 Dani, am I trying to get rid of compile and discouraged access warnings at the bottom of this page? http://download.eclipse.org/eclipse/downloads/drops4/I20140408-1645/testResults.php PW (In reply to Paul Webster from comment #6) > Dani, am I trying to get rid of compile and discouraged access warnings at > the bottom of this page? > > http://download.eclipse.org/eclipse/downloads/drops4/I20140408-1645/ > testResults.php > > PW This bug is about the Java compile warnings. The discouraged ones existed even in 3.x and it will probably be lots of work to fix them now. Released some fixes for platform ui/runtime http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b402b18bc22240c0cf8e8ed2f51afc3964423162 http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ea022825e2a6070bb4bebf373ce64552eab2265f http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e138669d524de5f273afa73737eaaf6313b5a6a2 http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=2c85691e062a7efcadbbb0cc7792ad7a4b5c0484 http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=b7fd0a962682df2715098f840fd8e31727f0bedc Within eclipse, I get a warning unless I include @SuppressWarning("unchecked"). http://download.eclipse.org/eclipse/downloads/drops4/I20140408-1645/compilelogs/plugins/org.eclipse.e4.emf.xpath_0.1.1.v20130515-1857/@dot.html 1. WARNING in /src/org/eclipse/e4/emf/internal/xpath/JXPathContextImpl.java (at line 86) @SuppressWarnings("unchecked") Unnecessary @SuppressWarnings("unchecked") PW (In reply to Paul Webster from comment #8) > Within eclipse, I get a warning unless I include > @SuppressWarning("unchecked"). > > http://download.eclipse.org/eclipse/downloads/drops4/I20140408-1645/ > compilelogs/plugins/org.eclipse.e4.emf.xpath_0.1.1.v20130515-1857/@dot.html > > 1. WARNING in /src/org/eclipse/e4/emf/internal/xpath/JXPathContextImpl.java > (at line 86) > @SuppressWarnings("unchecked") > Unnecessary @SuppressWarnings("unchecked") > > PW This happens because the project specific compiler option [ ] Ignore unavoidable generic type problems due to raw APIs. is not enabled. (In reply to Dani Megert from comment #10) > (In reply to Paul Webster from comment #8) > > Within eclipse, I get a warning unless I include > > @SuppressWarning("unchecked"). > > > > http://download.eclipse.org/eclipse/downloads/drops4/I20140408-1645/ > > compilelogs/plugins/org.eclipse.e4.emf.xpath_0.1.1.v20130515-1857/@dot.html > > > > 1. WARNING in /src/org/eclipse/e4/emf/internal/xpath/JXPathContextImpl.java > > (at line 86) > > @SuppressWarnings("unchecked") > > Unnecessary @SuppressWarnings("unchecked") > > > > PW > > This happens because the project specific compiler option > [ ] Ignore unavoidable generic type problems due to raw APIs. > is not enabled. I've fixed that. (In reply to Dani Megert from comment #11) > > I've fixed that. Thanks Dani. I've done a couple more: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=31d49147a2fa7c327633dbc42ab73c36577e4926 PW I think this is not "only" about the build but about warning messages in general -> adjusted the title *** Bug 428355 has been marked as a duplicate of this bug. *** (In reply to Lars Vogel from comment #13) > I think this is not "only" about the build but about warning messages in > general -> adjusted the title No this is about the warnings we still have in the build. Mirco fix in Workbench https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c0269496de051b9ebfdd85bfba470669a0365eea Lars, it would be good if we can get rid of them for 4.5. Current state: org.eclipse.e4.tools.compat_1.0.0.N20150326-2000 0 2 org.eclipse.e4.tools.emf.ui_1.0.0.N20150326-2000 0 8 org.eclipse.e4.ui.css.core_0.10.200.N20150326-2000 0 111 org.eclipse.e4.ui.services_1.1.0.N20150326-2000 0 15 org.eclipse.e4.ui.tests.css.swt_0.9.1.N20150326-2000 0 13 org.eclipse.e4.ui.workbench.swt_0.12.100.N20150326-2000 0 40 org.eclipse.e4.ui.workbench_1.3.0.N20150326-2000 0 45 (In reply to Dani Megert from comment #18) > Current state: > > org.eclipse.e4.tools.compat_1.0.0.N20150326-2000 0 2 > org.eclipse.e4.tools.emf.ui_1.0.0.N20150326-2000 0 8 > org.eclipse.e4.ui.css.core_0.10.200.N20150326-2000 0 111 > org.eclipse.e4.ui.services_1.1.0.N20150326-2000 0 15 > org.eclipse.e4.ui.tests.css.swt_0.9.1.N20150326-2000 0 13 > org.eclipse.e4.ui.workbench.swt_0.12.100.N20150326-2000 0 40 > org.eclipse.e4.ui.workbench_1.3.0.N20150326-2000 0 45 Dani, how one can correlate the results above with Eclipse compiler settings we use for the projects above? Is there some "default" preferences file for jdt one can download and apply to the projects (at least locally) so that one can see exact those numbers above in the Problems view and kill them one-by-one? I'm willing to spend time on it, but I fear that I introduce even more warnings similar to bug 463618. (In reply to Andrey Loskutov from comment #19) > (In reply to Dani Megert from comment #18) > > Current state: > > > > org.eclipse.e4.tools.compat_1.0.0.N20150326-2000 0 2 > > org.eclipse.e4.tools.emf.ui_1.0.0.N20150326-2000 0 8 > > org.eclipse.e4.ui.css.core_0.10.200.N20150326-2000 0 111 > > org.eclipse.e4.ui.services_1.1.0.N20150326-2000 0 15 > > org.eclipse.e4.ui.tests.css.swt_0.9.1.N20150326-2000 0 13 > > org.eclipse.e4.ui.workbench.swt_0.12.100.N20150326-2000 0 40 > > org.eclipse.e4.ui.workbench_1.3.0.N20150326-2000 0 45 > > Dani, how one can correlate the results above with Eclipse compiler settings > we use for the projects above? This is pretty easy: the builder (usually - see last paragraph below) uses the defaults except for deprecation warnings (Ignore) and also ignores unavoidable generic type problems due to raw APIs. So, simply start with a new workspace (or reset the 'Errors/Warnings' preferences), make those two changes, and then on the UI project(s) uncheck 'Enable project specific settings'. NOTE: Some UI projects (not the ones listed above) tweak the options used by the official build. Look out for <code.ignoredWarnings> in the pom.xml. New Gerrit change created: https://git.eclipse.org/r/45269 Gerrit change https://git.eclipse.org/r/45269 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3a2fa1fad22a05ba57dcc425cf4dc199eb53e85a New Gerrit change created: https://git.eclipse.org/r/45299 New Gerrit change created: https://git.eclipse.org/r/45300 New Gerrit change created: https://git.eclipse.org/r/45302 Gerrit change https://git.eclipse.org/r/45299 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a7a9831ec9324f493b778f2debe6366cca033fc3 New Gerrit change created: https://git.eclipse.org/r/45303 Gerrit change https://git.eclipse.org/r/45303 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=05ebbc7b4891a24ca95be20f5ebf33cf9e2b8833 New Gerrit change created: https://git.eclipse.org/r/45306 Gerrit change https://git.eclipse.org/r/45306 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c21b10add6637ba71ad6a82a5b4fa7a5d572e611 New Gerrit change created: https://git.eclipse.org/r/45308 Gerrit change https://git.eclipse.org/r/45308 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=aa3c28b81ab9773d9e5b98913e97a79d0d0f56ed I think I've fixed all warnings in platform from the list in comment 18, see http://download.eclipse.org/eclipse/downloads/drops4/N20150405-2000/testResults.php#PluginsErrors. Lars, can you please integrate those 2 patches below (I have no rights to push to e4 tools): https://git.eclipse.org/r/45300 https://git.eclipse.org/r/45302 Gerrit change https://git.eclipse.org/r/45300 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=96ab90fcc2742e9aa7e7bc8fa2c23a19a37894a6 Gerrit change https://git.eclipse.org/r/45302 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=03679fe6f9e1efc1c6837b4a9ffa9dd3eb9e51ab (In reply to Andrey Loskutov from comment #33) > I think I've fixed all warnings in platform from the list in comment 18, see > http://download.eclipse.org/eclipse/downloads/drops4/N20150405-2000/ > testResults.php#PluginsErrors. Thanks Andrey, I think this is fixed with your series of patches. Verified by looking really hard at http://download.eclipse.org/eclipse/downloads/drops4/I20150428-0100/testResults.php |