Bugzilla – Full Text Bug Listing
| Summary: | Initial width of left-hand pane is too small | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> | ||||
| Component: | Client | Assignee: | Mark Macdonald <mamacdon> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | libingw | ||||
| Version: | 3.0 | ||||||
| Target Milestone: | 4.0 RC1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=08db397 I just wanted to increase the left-hand pane width on the editor page, but kept hitting bugs in splitter.js. Summary: 1) The splitter's "closeByDefault" param was broken. All it did was reset the splitter width to 150px (unless you also used a "left:0%" hack like in (2)). This has been fixed. * However, fixing this revealed that the splitter on the editor page is supposed to be closed sometimes, by design. Opened bug 418558 to change that, since it feels wrong. 2) Setting "left:0%" on the splitter to achieve an initial "closed" state is not allowed anymore. Instead the style gives the splitter's size when it is first opened. Pages must set a sane style on the splitter, like "left:25%", or just leave it to the theme default. 3) Splitter now allows its initial open/closed state to be set via a data attribute on the DOM node. This is cleaner than style hacks, and doesn't require any JS. (In reply to Mark Macdonald from comment #1) > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/ > ?id=08db397 > > I just wanted to increase the left-hand pane width on the editor page, but > kept hitting bugs in splitter.js. Summary: > > 1) The splitter's "closeByDefault" param was broken. All it did was reset > the splitter width to 150px (unless you also used a "left:0%" hack like in > (2)). This has been fixed. > * However, fixing this revealed that the splitter on the editor page is > supposed to be closed sometimes, by design. Opened bug 418558 to change > that, since it feels wrong. > > 2) Setting "left:0%" on the splitter to achieve an initial "closed" state is > not allowed anymore. Instead the style gives the splitter's size when it is > first opened. Pages must set a sane style on the splitter, like "left:25%", > or just leave it to the theme default. > > 3) Splitter now allows its initial open/closed state to be set via a data > attribute on the DOM node. This is cleaner than style hacks, and doesn't > require any JS. I am not quite sure what 1) means but 2) and 3) are much cleaner approaches. Cool. |
Created attachment 236018 [details] screenshot of pane too small 1. Load the Orion coding page and run `localStorage.clear()` from your browser's JS console. 2. Reload the page. 3. The initial width of the left-hand pane is too small to see much of anything. The default width is ~150px. This might have been sufficient in 3.0 when the left-hand nav was drilled in on a single folder, but in 4.0 the entire folder tree is shown, so more width is needed.