Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 418415

Summary:	Editor commands not displayed
Product:	[ECD] Orion	Reporter:	Malgorzata Janczarska <malgorzata.tomczyk>
Component:	Editor	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	maciej.bendkowski, Silenio_Quarti
Version:	4.0
Target Milestone:	4.0 RC1
Hardware:	PC
OS:	All
Whiteboard:

Description Malgorzata Janczarska

2013-10-01 08:21:18 EDT

Editor commands, both contributed by Orion and by plugins are not displayed.

Comment 1 Malgorzata Janczarska

2013-10-01 08:27:46 EDT

visibleWhen on Save commands was checked before inputManager was set that caused error that broke checking for every next visibleWhen. I added a null check and it fixed the problem.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5e66ac3ec1cbbb19bb4685991e0dc8028929926d
Silenio, please verify if the fix is OK.

Comment 2 Silenio Quarti

2013-10-01 11:25:51 EDT

Thanks for catching this.

The inputManager should not be null in editorCommands.js as it is passed in the constructor.  The problem here is that I fall for the usual wrong "this" in JS. 

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e311ffe6f9e9e3f1a571b38ccace51f163ee461a