Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 418187

Summary:	Folder spasm when clicking between 2 expanded folders in mini-nav
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	maciej.bendkowski, Silenio_Quarti
Version:	3.0
Target Milestone:	4.0 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2013-09-27 10:38:09 EDT

Whenever you click a folder name in the mini-nav, the folder gets selected, and also expands or collapses. But when when you're changing the selection from 1 expanded folder to another, you get a surprising expanded->collapsed->expanded animation.

1. Have 2 collapsed folders in your nav, "A" and "B".
2. Click on A to expand it.
3. Click on B to expand it.
4. Now -- with the list selection still on B -- click A again.

Expected behavior: A gets selected and collapses.

Actual behavior: A gets selected and collapses, then immediately expands again. This looks weird.

Comment 1 Silenio Quarti

2013-09-27 14:43:33 EDT

This is caused by the changes for bug#418078. It immediately expands again because it become resource being edited.

Comment 2 Silenio Quarti

2013-09-27 14:51:02 EDT

I do not see any way of having both bugs fixed.  Mark/Maciej, which behavior works better for you?  My first impression is that the code for bug#418078 should be removed given that it is not adding a lot. Anything that can be done on the mini nav, can be done on the folder nav. We do not really have to have the same content visible on both.

Comment 3 Maciej Bendkowski

2013-09-30 04:20:49 EDT

(In reply to Silenio Quarti from comment #2)
> I do not see any way of having both bugs fixed.  Mark/Maciej, which behavior
> works better for you?  My first impression is that the code for bug#418078
> should be removed given that it is not adding a lot. Anything that can be
> done on the mini nav, can be done on the folder nav. We do not really have
> to have the same content visible on both.

Given that we don't have much time to figure out a better way out here, I think we should follow your suggestion, Silenio. Regardless, I would strongly suggest to rethink the presence of both the mini-nav and folder-nav. They duplicate functionality and, as pointed out in this bug, cannot be synchronized well leading to inconsistent representation. I can't notice any clear advantage in having them both.

Comment 4 Silenio Quarti

2013-09-30 10:15:12 EDT

We should discuss the two navs issue on a UX call.

For now I have removed changes for bug#418187

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=085b7d1d0baa5a0880cab46707a32a9be460c36c