Bugzilla – Full Text Bug Listing
| Summary: | [Themes] GTK theme toolbar gradient looks bad | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Robin Stocker <robin> | ||||||||
| Component: | UI | Assignee: | Paul Webster <pwebster> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Daniel Rolka <daniel.rolka> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | daniel_megert, gheorghe, Lars.Vogel | ||||||||
| Version: | 4.4 | ||||||||||
| Target Milestone: | 4.4 M3 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux-GTK | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | 420035 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
Bogdan, any hint on where we're generating that gradient? PW Ping? Is eclipse.platform.ui the right repository to find this? Any hints where to start looking or put a breakpoint? I think I found it (with lots of googling). This looks good: https://git.eclipse.org/c/platform/eclipse.platform.git/tree/platform/org.eclipse.platform/css Now to figure out how to run with these definitions. https://git.eclipse.org/c/platform/eclipse.platform.git/tree/platform/org.eclipse.platform/plugin.xml#n128 is where those stylesheets are attached to themes on the Preferences>General>Appearance pref page. PW Thanks Paul, I have it working here. It depends on changes in the theme engine so that SWT color constants can be used as part of gradients. I'll push to Gerrit soon. By the way, do you know the answer to bug 402530 comment 4? (In reply to Robin Stocker from comment #5) > Thanks Paul, I have it working here. It depends on changes in the theme > engine so that SWT color constants can be used as part of gradients. I'll > push to Gerrit soon. By the way, do you know the answer to bug 402530 > comment 4? No, I don't know. You should open a new bug and we'll put Bogdan and Daniel R on it to see if it should be made consistent. AFAIK we're supposed to translate anything like org.eclipse.ui to org-eclipse-ui for CSS compatibility PW (In reply to Paul Webster from comment #6) > No, I don't know. You should open a new bug and we'll put Bogdan and Daniel > R on it to see if it should be made consistent. > > AFAIK we're supposed to translate anything like org.eclipse.ui to > org-eclipse-ui for CSS compatibility Done, see bug 420036. For implementing a better gradient, it would help if the gradient could be defined using a system color. I openend bug 420035 with a patch for making this possible. Created attachment 236820 [details]
before change
Created attachment 236821 [details] after change Proposed change: https://git.eclipse.org/r/17703 The attachment "after change" shows how it looks with the above change. Compare it to "before change". IMO it is much more pleasant to look at. Released as http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=c30d6d98601afb60275cb2d7e870d60f1a47e647 Thanks Robin. PW In 4.4.0.I20131028-2000 PW |
Created attachment 235675 [details] toolbar gradient (magnified 4 times) See attached picture (left side) for how the toolbar looks on Linux with Eclipse 4.4 M1. The problem is that the gradient does not fade smoothly into the other area at the bottom. On the right, I manually removed the bottom part of the gradient which makes it much better already. The gradient of the Package Explorer tab on the other hand is so nice that I don't want to stop looking at it ;). The problem may be caused by a technical limitation. If that's the case, it should be considered to remove the gradient until it can be fixed. I am very willing to provide patches, but don't know where to look yet, so some hints would be appreciated. There are other bugs about the theme but I didn't find one specifically for this.