Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 417362

Summary: many errors in e4Build workspace due to Orion cleanup
Product: [ECD] Orion Reporter: David Williams <david_williams>
Component: RelengAssignee: Project Inbox <orion.releng-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, pwebster
Version: unspecified   
Target Milestone: 4.0 M2   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 417942    
Attachments:
Description Flags
zip of exising logs none

Description David Williams CLA 2013-09-16 14:19:58 EDT
At least, I think they are mostly from Orion cleanup. 

But, my concern here is that we have anything under generic "e4Build/workspace". 

Each builder/operation should specify its own "workspace", at a "safe" location so we don't accidentally step on each others workspace logs. 

I am not sure of the best way to fix this ... but know of a "quick and easy" way to do it. 

I'll create a directory under e4Build named "cleanupworkspaces" and then in 'cleanup.sh' I'll include an argument to the java call that specifies 
-data ${HOME}/cleanupworkspaces/workspace-cleanup

That will at least avoid "main" risk of stepping on builds/logs from elsewhere. 

I was looking at this workspace, trying to find an error in our SDK build (which does "cleanup" differently BTW) and couldn't find it ... so still not sure where maven puts workspaces, by default. But, having e4Build free of "home workspace" will make it easier to spot other, similar mistakes in future. 

If/when anyone wants to improve cleanup.sh so orion's logs go one place, e4 logs go somewhere else, etc. feel free ... but that'll take a little more knowledge/time than I have. 

For the current "home workspace", I'll move it under cleanupworkspaces with a unitque name, such as workspace09172014 and future ones will just be under cleanupworkspaces/workspace-cleanup unless someone does more work.
Comment 1 David Williams CLA 2013-09-16 14:25:54 EDT
Files moved, and cleanup.sh changed so workspace specified: 

$java -jar $launcherJar -data "${HOME}/cleanupworkspaces/workspace-cleanup" -application org.eclipse.ant.core.antRunner -f cleanupScript.xml cleanup -DcompositeRepo=$compositeRepo


Feel free to reopen if you'd like to improve on the solution ... and/or if the "failures" in the log signify anything important!
Comment 2 David Williams CLA 2013-09-16 14:30:32 EDT
Oh, just remembered ${HOME} might not be defined if ran from a cron job, so changed to hard coded to e4Build's home: 

$java -jar $launcherJar -data "/opt/buildhomes/e4Build/cleanupworkspaces/workspace-cleanup" -application org.eclipse.ant.core.antRunner -f cleanupScript.xml cleanup -DcompositeRepo=$compositeRepo
Comment 3 David Williams CLA 2013-09-16 14:43:35 EDT
Created attachment 235542 [details]
zip of exising logs

Sorry, went to the trouble to "gather" the logs with errors, then forgot to attach ... for your convenience.
Comment 4 David Williams CLA 2013-09-17 13:30:46 EDT
FWIW, "stuff" is being written to /opt/buildhomes/e4Build/cleanupworkspaces/workspace-cleanup/.metadata, but no log yet. 

Also, someone/somewhere is still creating .../e4Build/workspace ... but, no .log so hard to know "who". 

The maven/tycho builds ... the eclipserun-plugin, that is, does create "workspace" directly under the project they are running in, I've learned.