| Summary: | [Shell] Asynchronous argument proposals are broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Maciej Bendkowski <maciej.bendkowski> | ||||
| Component: | Client | Assignee: | Grant Gayed <grant_gayed> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | simon_kaegi | ||||
| Version: | 4.0 | ||||||
| Target Milestone: | 4.0 M2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I think that the change for "Bug 374575 - Allow two-way communication between plugins/iframes and the host page" has resulted in objects that have functions (such as the parse invocation's "arg" argument) to lose their field values before being sent. Am looking further. Spoke to Simon, the correct thing to do here is to not pass an object with both fields and prototype functions, since the functions necessitate arg being sent to the plugin as an object reference instead of a plain object. Fixed > 20130913, commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=28f685a13660a3ab9aecdb5ca4e3eaba3fa7c6eb . |
Created attachment 235464 [details] TypeError exception Recently I've noticed, that the asynchronous argument proposals are broken. Service calls succeed, however they are not displayed as proposals to the end user. When I try to update a logger level, I get an typeError from the cli.js 9see attachment). It worked for some time, and now it's broken. I haven't updated the log service plugin. Grant, is this related to your recent shell commits?