Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 416954

Summary:	-perspective at product program arguments is not working in 4.2M6
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	IDE	Assignee:	Daniel Rolka <daniel.rolka>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	bugs.eclipse.org, curtis.windatt.public, cvgaviao, daniel.rolka, daniel_megert, emoffatt, Lars.Vogel, me, philip.wenig, pwebster
Version:	4.2
Target Milestone:	4.3.2
Hardware:	PC
OS:	All
Whiteboard:
Bug Depends on:	377981
Bug Blocks:

Description Paul Webster

2013-09-10 14:24:28 EDT

Backport fix to 4.3.2

+++ This bug was initially created as a clone of Bug #377981 +++

Build Identifier: 4.2 M6

The program arguments of the product configuration of my project has this: -perspective myDefaultPerspective

But after start the runtime the perspective that appears is Resource.

This works properly in Eclipse Indigo.

Reproducible: Always

Steps to Reproduce:
1. create a product configuration and add -perspective <your perspective>
2. use as product: org.eclipse.platform.ide
3. use as Application: org.eclipse.ui.ide.workbench

Comment 1 Daniel Rolka

2013-09-12 09:05:32 EDT

Gerrit review link: https://git.eclipse.org/r/#/c/16351/

Comment 2 Dani Megert

2013-09-18 07:11:27 EDT

(In reply to Daniel Rolka from comment #1)
> Gerrit review link: https://git.eclipse.org/r/#/c/16351/

The fix is quite big for 4.3.2. Is this really important enough for being backported?

Comment 3 Dani Megert

2013-09-18 10:53:38 EDT

See bug 417399 for a follow-up issue.

Comment 4 Paul Webster

2013-09-20 10:13:17 EDT

(In reply to Dani Megert from comment #2)
> 
> The fix is quite big for 4.3.2. Is this really important enough for being
> backported?

I was pushing for this because its a regression and there's no way to replicate this functionality for RCP applications that wish to force a starting perspective (I wanted an improved path for RCP apps to migrate to Kepler).

But if it's too risky I'm willing to defer it (which would just close this bug as it's already in Luna)

PW

Comment 5 Dani Megert

2013-09-20 11:49:46 EDT

(In reply to Paul Webster from comment #4)
> (In reply to Dani Megert from comment #2)
> > 
> > The fix is quite big for 4.3.2. Is this really important enough for being
> > backported?
> 
> I was pushing for this because its a regression and there's no way to
> replicate this functionality for RCP applications that wish to force a
> starting perspective (I wanted an improved path for RCP apps to migrate to
> Kepler).
> 
> But if it's too risky I'm willing to defer it (which would just close this
> bug as it's already in Luna)
> 
> PW

What worries me, is that the patch not just adds code to make the perspective appear if needed i.e. it contains code changes which are run even without -product being used. Plus, I think, an RCP writer can easily choose the initial perspective in the code. Personally, I would not backport this but I'd also not -1 it, if you think it's important and safe.

Comment 6 Paul Webster

2013-11-04 15:16:28 EST

OK, It's probably not worth the risk to patch this back to 4.3.2

Thank you for your effort, Daniel.

PW