Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 416573

Summary: some cleanup of content assist code
Product: [ECD] Orion Reporter: Manu Sridharan <m.sridharan>
Component: JS ToolsAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: unspecified   
Target Milestone: 4.0 M2   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Manu Sridharan CLA 2013-09-04 16:55:34 EDT 
I've implemented some cleanup of the content assist code on this branch:

https://github.com/msridhar/orion.client/tree/cleanup

The commit is:

https://github.com/msridhar/orion.client/commit/a0e6b3fc9338d2d82ab4cc0e9a53a30d60eef861

A key change is that esprimaJsContentAssist.js is now much smaller, as the logic for type environments and type inference has been extracted to separate modules.

Let me know how the change looks.
Comment 1 Mark Macdonald CLA 2013-09-13 15:05:19 EDT 
Looks great. I'm a big fan of smaller modules.

Pushed: