Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 415094

Summary: [run control] Update step into selection JUnit tests
Product: [Tools] CDT Reporter: Marc Khouzam <marc.khouzam>
Component: cdt-debug-dsf-gdbAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: alvaro.sanchez-leon, cdtdoug, eclipse.sprigogin, pawel.1.piech
Version: 8.2   
Target Milestone: 8.6.0   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Marc Khouzam CLA 2013-08-14 13:31:22 EDT
Taken from bug 244865 commetn 32:

While working on making the JUnit test properly pass, I reviewed the StepIntoSelection Unit tests and made some modification.  I changed the tests a lot so it proved much faster to do it myself than to write comments for the changes.  The main changes are:

1- complete the set of test files/suites to run the stepIntoSelection tests for every version of GDB
2- simplify the test app greatly.  From experience, once a test stops working, a complicated test app makes debugging quite difficult
3- added some tests
4- simplified the test code

Note that with these changes, I noticed that an assertion is hit in the all-stop stepIntoSelection.  I haven't fixed it yet.

I've posted the changes to gerrit:
  https://git.eclipse.org/r/13840
Comment 1 Marc Khouzam CLA 2013-08-14 14:51:28 EDT
I've pushed patchset 4 to gerrit addressing Alvaro's comments.

I've committed to master from gerrit.