Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 414765

Summary:	CTRL+Q keyboard shortcut in any dialog closes the workbench without option to save
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	major
Priority:	P3	CC:	daniel_megert, emoffatt, markus.kell.r, pelder.eclipse, pwebster, tobias.melcher
Version:	4.2
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	411602
Bug Blocks:

Description Paul Webster

2013-08-09 08:32:41 EDT

+++ This bug was initially created as a clone of Bug #411602 +++

Steps to reproduce the issue:
- open java editor 
- press CTRL-O to view inplace outline
- press CTRL-Q
==> eclipse is surpisingly closed

CTRL-Q keyboard shortcut for java editor triggers a "Jump to last modification". 
The workbench should not be closed if I press CTRL-Q if the inplace outline view is open. 

Class org.eclipse.e4.ui.internal.workbench.ExitHandler is internally called. 
Is this really the intended behavior?

With best regards,
Tobias Melcher

Comment 1 Paul Webster

2013-08-09 08:33:35 EDT

We still need a fix for the fact that window keybindings are restricted when a dialog has the focus.

PW

Comment 2 Dani Megert

2013-08-09 08:40:28 EDT

(In reply to comment #1)
> We still need a fix for the fact that window keybindings are restricted when
> a dialog has the focus.
> 
> PW

What are the steps? The ones from comment 0 seem fixed and also the ones with the About Dialog (bug 411602 comment 2).

Comment 3 Dani Megert

2013-08-12 08:11:22 EDT

I can't reproduce this bug using 4.4 M1 on Windows 7 (32 and 64-bit).

Comment 4 Markus Keller

2013-08-12 10:25:04 EDT

I see two remaining issues:

On Windows, when I bind Exit to Ctrl+Alt+Q in context "In Dialogs and Windows", then I see the same behavior as the Mac shows out of the box for Command+Q:

I can still exit Eclipse by pressing the shortcut even when the About or Open Resource dialog is open. However, I do get the "Save changes?" dialog if there are dirty files, so this doesn't lose data any more.

The "Confirm Exit" dialog is still missing, but that's bug 375744.

Comment 5 Paul Webster

2013-08-12 11:26:53 EDT

(In reply to comment #4)
> I see two remaining issues:
> 
> On Windows, when I bind Exit to Ctrl+Alt+Q in context "In Dialogs and
> Windows", then I see the same behavior as the Mac shows out of the box for
> Command+Q:
> 
> I can still exit Eclipse by pressing the shortcut even when the About or
> Open Resource dialog is open. However, I do get the "Save changes?" dialog
> if there are dirty files, so this doesn't lose data any more.

This is expected behaviour.  You've bound your exit command while in dialog and windows, and it should execute while the About dialog is up.

I opened this because I thought if you bound CTRL+ALT+Q to Exit "In Windows" it would work while the About dialog is up.  But I tried that, and it looks like it won't exit (which is what I want).  Also, I can't reproduce the problem from comment #0 with CTRL+Q bound to exit in Windows.

PW