Bugzilla – Full Text Bug Listing
| Summary: | New SWT table actions (Checking checked-state of checkboxes in first column) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] Jubula | Reporter: | Jan Philipp Wiegmann <Jan.Wiegmann> | ||||||||
| Component: | RC | Assignee: | Markus Tiede <markus.tiede> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | Oliver Goetz <Oliver.Goetz> | ||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | alexandra.schladebeck | ||||||||
| Version: | unspecified | Keywords: | triaged | ||||||||
| Target Milestone: | 2.2 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Cool! We'll need unbound modules and tests and docu for them. I wonder whether 2) and 3) should actually be one action. Our other table actions use "check ... in column" (and the column can be entered either with an index or a string). We probably also need a "check selection of checkbox in row" (again, supporting index and string (row header)). Having spoke to Marvin, I'm changing my last comment: - We don't need an action to check by column value : in SWT, it can only be in the first column. - However, for the second action "check selection of checkbox by row", the point I made is still valid -> the row parameter should accept index and string. After yet further discussion, we decided not to implement the "check by row", since the row can be seelcted with other actions. Jan - as discussed, can you add the patches for : - check selection of checkbox at mouse position - check selection of checkbox in selected cell Created attachment 234457 [details]
Reworked table actions
I also changed the names of the actions to "Check Selection of Checkbox in Selected Row" and "Check Selection of Checkbox in Row of Mouse Position" due to discussion with MT.
Created attachment 235088 [details]
Table actions: Toggle and Check Checkbox
I revised the actions and added actions for toggling checkboxes in selected row and checking the selection state of them.
To sum the actions up: 1. Check Selection of Checkbox at Mouse Position 2. Check Selection of Checkbox in Selected Row 3. Toggle Checkbox at Mouse Position 4. Toggle Checkbox in Selected Row They are mounted on concrete level so it cana be used in other toolkits as well (after implementation). The patch is currently not applicable to HEAD of master: error: patch failed: org.eclipse.jubula.toolkit.provider.concrete/src/org/eclipse/jubula/toolkit/provider/concrete/I18nStrings.properties:73 error: org.eclipse.jubula.toolkit.provider.concrete/src/org/eclipse/jubula/toolkit/provider/concrete/I18nStrings.properties: patch does not apply error: patch failed: org.eclipse.jubula.tools/src/org/eclipse/jubula/tools/objects/event/TestErrorEvent.java:22 error: org.eclipse.jubula.tools/src/org/eclipse/jubula/tools/objects/event/TestErrorEvent.java: patch does not apply Please re-generate an applicable patch and re-attach it. To check whether it's valid use "git apply <patch2Patch> --check" on your own clean jubula master. This patch works on my repository. I'm only able to apply the patch when explicitly using "--ignore-space-change" - this is strange. Patch has been reviewed and applied with http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=aef3494f792d468ff234c83c0ebf12cd9c16e38e Verified, caa tests have been added. |
Created attachment 234195 [details] Patch adding new table actions I have added 3 new actions applicable to SWT tables: 1. Check Selection of Checkbox in Selected Cell 2. Check Selection of Checkbox by Index 3. Check Selection of Checkbox by Value Patch to review is attached.