Bugzilla – Full Text Bug Listing
| Summary: | [themes] export themes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mike Kucera <mikekucera> | ||||||
| Component: | Client | Assignee: | Ken Kumagai <theken> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | antonm, ken_walker, theken | ||||||
| Version: | 3.0 | ||||||||
| Target Milestone: | 5.0 M1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Mike Kucera
Created attachment 237517 [details]
export button
Created attachment 237518 [details]
click export button
I created a fix that exports the current color theme into importable xml format. https://github.com/theken55/orion.client/commit/6cb5ca571826b7b3b7afd49acd7ae01efaf562e6 https://github.com/theken55/orion.client/commit/3e833ec5df671bcce9fe9c90e3d9b0196dcef492 I implemented "export theme" that exports as alert message, not a file because "import theme" imports from input field, not file. I attached screen shots of implementation. Here are detailed information of implementation: - During export, values of ThemeBuilder.zones are set in attributes of xml. - Export button is added on editor page in settings. - Tags of overviewRuler, annotationRuler, attribute are exported for future enhancement because they are not imported in ThemeData#importTheme now. This seems a neat addition. I plan to review this for committing in the next day or two. This seems good in general. My one note is that it doesn't seem to save the theme name in the output. I think that would be helpful. Otherwise it seems to output well and re-input well. There are warnings in the code too - for example dat['lineNumber'] should be dat.lineNumber - you can see the warnings in Orion. But it runs well. Why did you choose this task for Orion, out of curiousity? Thanks, Anton. I think saving the theme name in output is nice, too. I'll soon implement input dialog (such as clicking "New Folder") by referring /org.eclipse.orion.client.ui/web/orion/fileCommands.js. yes, come from curiosity. And I think Orion with both import and export would be much better than Orion with only import. Anton I fixed warnings, and added an input field (tool tip?) to save the theme name in the output. https://github.com/theken55/orion.client/commit/310d33bcf6bc0eda8b129c14c2828ea5fc3f54e9 We had to do a slight rebase and I decided to reformat that file so it looks like a complete change but the changes have been merged. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c2885341998445349e6e426883a7955f9b287d3e |