| Summary: | Mixed Content Warning in IE8 on SSL | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Arnaud MERGEY <a_mergey> | ||||
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | ivan, rsternberg, tbuschto | ||||
| Version: | 2.1 | ||||||
| Target Milestone: | 2.2 M2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | sr212 | ||||||
| Attachments: |
|
||||||
|
Description
Arnaud MERGEY
Created attachment 234074 [details]
Warning popup screenshot
In order to avoid "mixed content warning" we need absolute URLs for background images (see bug 289822 and bug 311694). Before this was done by Alias.js, which has been removed in RAP 2.0M2 (see bug 384157). We can consider this as a regression. ... see also this bug 285815. As of commit 761b3ac34baac0ffc6255c3dd6c38134c59d913f URLs are re-written to absolute paths before a background-image is set (in old IE only). Waiting for confirmation that this fixes the issue before closing the bug. Widget.js#styleBackgroundImage and Text.js still use relative URLs... commit 175d958ed71fedbe3a0acc512eed39b830f1d87c takes care of those other two. I've tested both Controls and Workbench demo with SSL and IE8 and the mixed content warning is gone. Arnaud, can you confirm this? I will check this ASAP. Do you plan to fix it also for 2.1.1 ? For 2.1.1 is too late... but I think for 2.1.2 yes. I confirm it seems fixed now, tested ok on my apps +1 for backporting to 2.1.2. Since this is not a trivial change, I think that unless we can use Gerrit for maintenance branches, we should have an a patch for 2.1.2 that aggregates both commits. (In reply to comment #11) > +1 for backporting to 2.1.2. > Since this is not a trivial change, I think that unless we can use Gerrit for > maintenance branches, we should have an a patch for 2.1.2 that aggregates both > commits. There is still problem with this fix - see bug 426958. I prefer not to backport this fix till bug 426958 is fixed. Changes for RAP 2.1.2 https://git.eclipse.org/r/#/c/21380/ This includes the changes (including all tests) from commit 761b3ac34baac0ffc6255c3dd6c38134c59d913f commit 175d958ed71fedbe3a0acc512eed39b830f1d87c commit 00ef0c690d22bdc4d20925ab41a7023880912460 (of Bug 426958) JS Tests are OK in emulated IE8 and all current browser. I verified the URLs are rewritten in the DOM explorere and tested the missing images issue with "/" in the URL query string. Backported to 2.1-maintenance branch with change https://git.eclipse.org/r/21380 |