Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 414330

Summary: CTRL+Q keyboard shortcut in any dialog closes the workbench without option to save
Product: [Eclipse Project] Platform Reporter: Paul Webster <pwebster>
Component: UIAssignee: Paul Webster <pwebster>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: daniel_megert, emoffatt, markus.kell.r, pelder.eclipse, pwebster, tobias.melcher
Version: 4.2   
Target Milestone: 4.3.1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 411602    
Bug Blocks:    

Description Paul Webster CLA 2013-08-02 14:07:37 EDT 
Backport the model fix to 4.3.1

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8f2a2860a007b7321d03dcae23bb10941a12ffea

http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=c6f76d3ee70c56b52aa17b2e0db2e8cbbab219be

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1502559fa72c7786159fc0cd7fb626b4b09149a5


+++ This bug was initially created as a clone of Bug #411602 +++

Steps to reproduce the issue:
- open java editor 
- press CTRL-O to view inplace outline
- press CTRL-Q
==> eclipse is surpisingly closed

CTRL-Q keyboard shortcut for java editor triggers a "Jump to last modification". 
The workbench should not be closed if I press CTRL-Q if the inplace outline view is open. 

Class org.eclipse.e4.ui.internal.workbench.ExitHandler is internally called. 
Is this really the intended behavior?

With best regards,
Tobias Melcher
Comment 1 Paul Webster CLA 2013-08-09 14:47:38 EDT 
The 2 changes for eclipse.platform.ui:

https://git.eclipse.org/r/15300

https://git.eclipse.org/r/15301

The change for eclipse.platform:

https://git.eclipse.org/r/15302


Eric, can you please review these changes for 4.3.1?

PW
Comment 3 Dani Megert CLA 2013-08-21 11:23:29 EDT 
Verified in M20130821-0800.