Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 414027

Summary: Highlight item in git log and branch on hover
Product: [ECD] Orion Reporter: Gabriel Luong <gabriel.luong>
Component: ClientAssignee: Gabriel Luong <gabriel.luong>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: Szymon.Brandys
Version: 4.0Flags: gabriel.luong: review? (Szymon.Brandys)
Target Milestone: 4.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Gabriel Luong CLA 2013-07-30 11:26:39 EDT
Highlight the <tr> items in the git log and git branches.

I actually tried doing this, but since sectionTables are reused in git status, the hover would appear in the git status. Not quite sure if we wanted the hover on the git status. Otherwise, we need to add a new class to the items in specific sectionTables.
Comment 1 Szymon Brandys CLA 2013-07-31 07:33:02 EDT
I think we should have consistent behavior across Orion. So if we have highlighting in git-log it should be in all other places ie other git pages, sites, settings etc. Moreover just highlighting <tr> elements is bad.

Note that git-log already uses explorers with selection models while git-branches does not. What I would suggest is to introduce explorers with selection models to git-branches and other git pages that do not have that. Then add highlighting to Orion explorer.
Comment 2 Gabriel Luong CLA 2013-08-26 15:47:21 EDT
I added a hover effect for the git branches, remotes, tags and logs in the git repository pages. This will help significantly for users with a widescreen monitor due to the amount of whitespace we have in between the git item and the action buttons.

https://github.com/gabrielluong/orion.client/commit/313d76cfed10a47e19090b76c7657324e584ada9

I believe the plan to revise the git repository UI is gonna take an incremental approach as we make it to look closer like GitHub. 

The first step with this commit is to add the hover.
I will be working on making the buttons only appear when we hover over the row next. Afterwards, we will want to experiment with the look and feel with all the reminding whitespaces.
Comment 3 Gabriel Luong CLA 2013-08-26 15:47:28 EDT
I added a hover effect for the git branches, remotes, tags and logs in the git repository pages. This will help significantly for users with a widescreen monitor due to the amount of whitespace we have in between the git item and the action buttons.

https://github.com/gabrielluong/orion.client/commit/313d76cfed10a47e19090b76c7657324e584ada9

I believe the plan to revise the git repository UI is gonna take an incremental approach as we make it to look closer like GitHub. 

The first step with this commit is to add the hover.
I will be working on making the buttons only appear when we hover over the row next. Afterwards, we will want to experiment with the look and feel with all the reminding whitespaces.
Comment 4 Gabriel Luong CLA 2013-09-06 11:50:09 EDT
Review bump
Comment 5 John Arthorne CLA 2015-05-05 14:36:59 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html