Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 413917

Summary: allow to star a review
Product: z_Archived Reporter: Tomasz Zarna <tomasz.zarna>
Component: MylynAssignee: Project Inbox <mylyn-triaged>
Status: CLOSED MOVED QA Contact:
Severity: enhancement    
Priority: P3 Keywords: helpwanted
Version: 2.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 426505    
Bug Blocks:    

Description Tomasz Zarna CLA 2013-07-29 09:10:06 EDT
Currently, there seems to be no way to star a review.
Comment 1 Sam Davis CLA 2013-08-22 20:08:41 EDT
It's not clear to me how we would show this or whether it even makes sense in the Mylyn UI.
Comment 2 Tomasz Zarna CLA 2013-08-23 06:23:58 EDT
(In reply to comment #1)
> It's not clear to me how we would show this 

A Star/Unstar button in the header seems to be the most obvious approach. But even a button next to [Publish comments], [Fetch], etc would work for me.

> or whether it even makes sense in the Mylyn UI.

Well, I have a query in Task List with starred reviews. But in order to star a review I need to leave Eclipse.
Comment 3 Sam Davis CLA 2013-08-23 12:54:34 EDT
Interesting. I wonder how/whether we should support starring tasks in general. Perhaps there should be some mechanism that works for all connectors and that we could tie to the Gerrit notion of starred reviews. But given we already have categories and scheduling in the task list, maybe the only reason to support it is for consistency with the Gerrit web ui.
Comment 4 Tomasz Zarna CLA 2013-08-26 05:42:47 EDT
Maybe the least invasive approach would be having an attribute for the option, e.g. even a combo box with "Starred"/"Unstarred" would do.

(In reply to comment #3)
> Interesting. I wonder how/whether we should support starring tasks in general.

I understand your concern, the idea here is to add the option for Gerrit reviews only.
Comment 5 Tomasz Zarna CLA 2013-11-06 05:08:22 EST
btw, querying for starred reviews is covered in bug 414253
Comment 6 Leo Dos Santos CLA 2014-01-08 16:55:44 EST
Thank you for your request. The bug has been marked helpwanted though to indicate that we would be happy to support a community contribution to resolve it.
Comment 7 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn