Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 413753

Summary: Document Git/Gerrit setup for Eclipse Platform projects (direct push to Git repo)
Product: Community Reporter: Markus Keller <markus.kell.r>
Component: GitAssignee: Eclipse Webmaster <webmaster>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, denis.roy, krzysztof.daniel, thanh.ha
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: stalebug

Description Markus Keller CLA 2013-07-25 12:01:20 EDT
We've had a few cases in the past where Eclipse Platform repos were broken after Gerrit was enabled for them, e.g. bug 379652, bug 405017.

For various reasons, we still need direct push access to the canonical Git repo URLs, e.g ssh://<user>@git.eclipse.org/gitroot/platform/eclipse.platform.ui.git

http://wiki.eclipse.org/Gerrit#Enabling_Gerrit_for_your_Eclipse.org_Project
doesn't document this setup, probably because there's some FUD floating around the interwebs that says it's not safe. However, we never had any issues with it.

Can we document this setup as a third option on that wiki page?

If not, then please dump all the necessary setup info into this bug, so that we have a simple target to refer to when we open an "Enable Gerrit" request.

Necessary common requirements seem to be:
- don't touch permissions in /gitroot/<repo>
- change the Project Options from "Merge If Necessary" to "Fast Forward Only"
Comment 1 Thanh Ha CLA 2013-07-25 15:24:01 EDT
(In reply to comment #0)
> Necessary common requirements seem to be:
> - don't touch permissions in /gitroot/<repo>
> - change the Project Options from "Merge If Necessary" to "Fast Forward Only"

Instead of changing permissions on /gitroot/<repo> for platform we are using ACLs to add the Gerrit user leaving existing permissions untouched.
Comment 2 Denis Roy CLA 2014-05-07 16:12:08 EDT
Is this really an issue?
Comment 3 Thanh Ha CLA 2014-05-07 16:28:41 EDT
I think we found a way to solve this using only Gerrit permissions already via discussions in bug 418966. I would argue that platform developers should stop using the regular Git URLs altogether and use only the Gerrit URLs.

I think the only user that might still need this URL is e4build but we can add e4build into Gerrit Permissions for the platform repos too so that it doesn't need to use the regular SSH URLs.
Comment 4 Dani Megert CLA 2014-05-07 16:58:54 EDT
(In reply to Thanh Ha from comment #3)
> I think we found a way to solve this using only Gerrit permissions already
> via discussions in bug 418966. I would argue that platform developers should
> stop using the regular Git URLs altogether and use only the Gerrit URLs.
> 
> I think the only user that might still need this URL is e4build but we can
> add e4build into Gerrit Permissions for the platform repos too so that it
> doesn't need to use the regular SSH URLs.

We - the Eclipse project - want to own our repos and be able to use Git in the normal/default way and also be able to access our repos via SSH (for those with shell access). The status quo is fine and no pressure/request to change this.
Comment 5 Thanh Ha CLA 2014-05-07 21:04:49 EDT
(In reply to Dani Megert from comment #4)
> (In reply to Thanh Ha from comment #3)
> > I think we found a way to solve this using only Gerrit permissions already
> > via discussions in bug 418966. I would argue that platform developers should
> > stop using the regular Git URLs altogether and use only the Gerrit URLs.
> > 
> > I think the only user that might still need this URL is e4build but we can
> > add e4build into Gerrit Permissions for the platform repos too so that it
> > doesn't need to use the regular SSH URLs.
> 
> We - the Eclipse project - want to own our repos and be able to use Git in
> the normal/default way and also be able to access our repos via SSH (for
> those with shell access). The status quo is fine and no pressure/request to
> change this.

FWIW I didn't intend on forcing any changes. I wanted to point out that we were able to come up with a Gerrit permission set which provided similar settings to what Platform Git Hooks provided.

Also in case you were not aware Gerrit does have an SSH port too.
Comment 6 Dani Megert CLA 2014-05-08 03:30:07 EDT
(In reply to Thanh Ha from comment #5)
> Also in case you were not aware Gerrit does have an SSH port too.

I know. My point was more regarding the shell access.
Comment 7 Eclipse Genie CLA 2016-04-28 12:49:25 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Denis Roy CLA 2016-04-28 14:35:52 EDT
As we move towards using jGit instead of git, we won't consider this.