Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 413433

Summary:	Investigate and reconsider the use of .gitignore
Product:	[ECD] Orion	Reporter:	Maciej Bendkowski <maciej.bendkowski>
Component:	Server	Assignee:	Project Inbox <orion.server-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne, mamacdon, matthias.sohn
Version:	4.0
Target Milestone:	4.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Maciej Bendkowski

2013-07-22 07:13:15 EDT

We should reconsider the content of .gitignore files. Especially, whether they are actually required in master and/or what regular expressions do we need. My initial concerns came from fixing bug 413341.

Comment 1 John Arthorne

2013-07-22 10:40:19 EDT

We should have .gitignore in master. Otherwise everyone has to create and maintain it locally. Of course it should not be excluding things like .project so this is a bug in gitignore to fix (looks like it has been fixed already).

Comment 2 Mark Macdonald

2013-07-22 10:52:39 EDT

(In reply to comment #1)
>  it should not be excluding things like .project so this is a bug in gitignore 
> to fix (looks like it has been fixed already).

master still has the .project line in the top-level .gitignore, so I don't think this is fixed yet.

Comment 3 Maciej Bendkowski

2013-07-22 11:03:49 EDT

(In reply to comment #2)
> master still has the .project line in the top-level .gitignore, so I don't
> think this is fixed yet.

It even an empty .project file so I think we can get rid of it.
My fix in http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=54adbcfa49208c45a87b7738c8a09116b8727dd7 did not delete this file, because I wanted to get confirmation, that this file is really unused before I delete it.

Comment 4 Mark Macdonald

2013-07-22 11:14:55 EDT

(In reply to comment #3)
> It even an empty .project file so I think we can get rid of it.
> My fix in
> http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/
> ?id=54adbcfa49208c45a87b7738c8a09116b8727dd7 did not delete this file,
> because I wanted to get confirmation, that this file is really unused before
> I delete it.

Oops, I didn't realize we were talking about the server repository -- the client repo has a similar gitignore which also ignores Eclipse projects.

These were added while fixing bug 399023. Maybe they are important for the Maven build? I don't know.

Comment 5 John Arthorne

2013-07-23 09:27:40 EDT

(In reply to comment #4)
> Oops, I didn't realize we were talking about the server repository -- the
> client repo has a similar gitignore which also ignores Eclipse projects.
> 
> These were added while fixing bug 399023. Maybe they are important for the
> Maven build? I don't know.

I don't think they matter for the maven build. I have fixed the client repository with the same fix that was made in the server repository. .project at the root of the repository is ignored, but not in sub-folders.

Comment 6 John Arthorne

2013-07-23 09:28:28 EDT

Marking fixed, I think they are ok now.