| Summary: | [navigation] Last edit position's editor id for multi-page editors is "" | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Daniel Rolka <daniel.rolka> |
| Component: | Text | Assignee: | Dani Megert <daniel_megert> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, noopur_gupta, webredjo+eclipse |
| Version: | 4.3 | Flags: | noopur_gupta:
review+
|
| Target Milestone: | 4.3.1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 32214 | ||
|
Description
Daniel Rolka
(In reply to comment #0) > To reproduce it the #392414 has to be fixed first That "fix" is wrong and hence surfaces this issue here. Having said that, the last edit position's editor id is "" for multi-page editors. This should not be the case. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=a16b4fcfc9b70ad415eed9abf1f63e88d206af0f This fixes the scenario from bug 392414 comment 2, but most likely not the XML editor case (bug 392414) which got broken in 4.x. We should backport this, since a (good) change in the Platform now surfaces this problem (see bug 392414). *** Bug 392414 has been marked as a duplicate of this bug. *** Noopur, please test and review the fix. The patch looks good. Tested using PDE and text editor for xml files. Fixed in 'R4_2_maintenance' with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=a21cc84e51523fb812d55895b0d7aa9da739607a Verified in 4.4 using Build id: I20130804-2300 and verified for 4.3.1 using Build id: M20130731-0800. |