Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 413346

Summary: [outline] Support StyledText in outline
Product: [Technology] DLTK Reporter: Simon Bernard <sbernard>
Component: CommonAssignee: dltk.common-inbox <dltk.common-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: bruno.do.medeiros, contact, kaloyan, zulus
Version: 5.0   
Target Milestone: 5.2   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/36425
https://git.eclipse.org/c/dltk/org.eclipse.dltk.core.git/commit/?id=d473c2a75363ace72dc833bf66e60655cebd286b
Whiteboard:
Bug Depends on:    
Bug Blocks: 413518    
Attachments:
Description Flags
a patch for this bug
none
a additional patch
none
support of styledString in quick ouline.
none
support of styledString in content assist.
none
a path for this bug.
none
support of styledString in viewpart (scriptexplorer,...) none

Description Simon Bernard CLA 2013-07-19 11:40:30 EDT
It could be nice to provide support of StyledText in outline.

Developpers could register a labelprovider (through org.eclipse.dltk.ui.modelLabelProvide extension point) which could implement a IStyledLabelProvider to custom the outline.
Comment 1 Simon Bernard CLA 2013-07-19 12:41:12 EDT
Created attachment 233624 [details]
a patch for this bug

A patch inspired from JDT.
Comment 2 Simon Bernard CLA 2013-07-19 12:55:21 EDT
Created attachment 233626 [details]
a additional patch

an additional patch which replace all references of deprecated DecoratingModelLabelProvider by the new StyledDecoratingModelLabelProvider (without API break)
Comment 3 Simon Bernard CLA 2013-07-23 06:09:42 EDT
Created attachment 233697 [details]
support of styledString in quick ouline.

this patch add the support of styled string in quick outline.
Comment 4 Simon Bernard CLA 2013-07-23 06:11:09 EDT
Created attachment 233698 [details]
support of styledString in content assist.

This patch add support of styled string in content assist.
Comment 5 Simon Bernard CLA 2013-07-29 10:20:07 EDT
Created attachment 233889 [details]
a path for this bug.

I fix a regression I added on ScriptUILabelProvider.
Comment 6 Simon Bernard CLA 2013-07-29 10:23:27 EDT
Created attachment 233890 [details]
support of styledString in viewpart (scriptexplorer,...)

I fix a regression on package name.
Comment 7 Simon Bernard CLA 2013-11-07 09:00:49 EST
Hi, 
 I get no feedback about my patches ? Do you think it was able to integrated it for the next release ?
Comment 8 Simon Bernard CLA 2014-01-23 10:18:17 EST
ping ?
Comment 9 Simon Bernard CLA 2014-11-18 10:05:56 EST
pushed on gerrit : https://git.eclipse.org/r/#/c/36425/
Comment 10 Dawid Pakula CLA 2015-02-19 11:58:54 EST
@Kaloyan is this possible to push this into 5.2?
Comment 11 Kaloyan Raev CLA 2015-04-16 05:34:14 EDT
Simon, I apologize for the really long delay. I was able to test the suggested patch together with the one in bug 413518. It looks OK. There are just a few minor things to clean up in the code (see comments in Gerrit) and we are good to go.
Comment 12 Simon Bernard CLA 2015-04-16 10:52:44 EDT
I do the changes. I hope it's ok now. :)
Comment 14 Kaloyan Raev CLA 2015-04-17 04:54:08 EDT
Merged. Thanks for the contribution!
Comment 15 Simon Bernard CLA 2015-04-17 05:01:38 EDT
Kaloyan, will it be available in the next eclipse milestones (Mars M7) ?
Comment 16 Kaloyan Raev CLA 2015-04-17 05:10:57 EDT
Yes.
Comment 17 Kaloyan Raev CLA 2015-06-02 10:04:06 EDT
Closing.