Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 412622

Summary:	CTRL+H search needs to render the file link with find parameter.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon
Version:	3.0
Target Milestone:	4.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description libing wang

2013-07-09 16:20:21 EDT

Currently the CTRL+H search from editor renders file links but clicking on it does not bring the editor with the find bar. It is inconvenient and not consistent with the search page.

Comment 1 Mark Macdonald

2013-07-10 18:11:05 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a6c0307

^ I modified navigatorRenderer.createLink (used by the Ctrl+H dialog) so callers can pass in additional params to expand the URI template against when generating the editor URL. searchClient now provides "line" and "find" if known, so the dialog will generate better links.

This is kind of a cheat, as editor URLs are in theory pluggable, and should be opaque to us. To take advantage of these new params, other registered editors will have to deal with the params.line and params.find variables that we now provide.

I did add support for using a 'validationProperties' on an editor extension [1], like typical file commands can do. It should theoretically be possible to use a validationProperties to replace our template params with ones that your editor understands (eg. perhaps "LineNumber" rather than "line"). I experimented with that, but validationProperties are not powerful enough to really do much there.

[1] http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=de5cb08

Comment 2 libing wang

2013-07-11 09:13:30 EDT

Thanks, Mark.
It works great. I found another minor issue but it is not really related to this bug.
For example, if user types "com*view" in either search page or CTRL+H search, we translate it to ",find=com.*view,regEx=true" in the param.
But this part was broken in the search page anyway, I will open a new bug to address that.

Comment 3 libing wang

2013-07-11 09:43:40 EDT

(In reply to comment #2)
> Thanks, Mark.
> It works great. I found another minor issue but it is not really related to
> this bug.
> For example, if user types "com*view" in either search page or CTRL+H
> search, we translate it to ",find=com.*view,regEx=true" in the param.
> But this part was broken in the search page anyway, I will open a new bug to
> address that.

Bug 412765 opened for this.