Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 412531

Summary: IES43 TVT00260, TVT00300, TVT00370, TVT00470 OK and Cancel button are not externalized
Product: [ECD] Orion Reporter: Sae Ryun Lim <srlim>
Component: GitAssignee: Gabriel Luong <gabriel.luong>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: antonm, gabriel.luong, ken_walker, mamacdon
Version: 1.0Flags: gabriel.luong: review? (mamacdon)
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
OK and Cancel button none

Description Sae Ryun Lim CLA 2013-07-08 12:31:46 EDT
Created attachment 233229 [details]
OK and Cancel button

OK and Cancel button are not externalized

TVT00260
Reproduce:
(1) Log in
(2) Click the Webapp_example folder
(3) Click the index.html file
(4) Replace "MAKE THIS CHANGE" with "HelloWorld"
(5) Click on the hamburger button and select the Git Status option
(6) Click on the arrow button to expand the index.html file
(7) Click on the Compare button
(8) Click on the Generate Link button
(9) Verify the buttons

TVT00300
Reproduce:
(1) Log in
(2) Click the Webapp_example folder
(3) Click the index.html file
(4) Replace "MAKE THIS CHANGE" with "HelloWorld"
(5) Click on the "hamburger" button and select the "Git Status" option
(6) Click on the arrow button to expand the "index.html" file
(7) Click on the "Reset" button under "Commit for [master} branch" section
(8) Verify the buttons

TVT00370
Reproduce:
(1) Log in
(2) Click on the "hamburger" button
(3) Select the "Sites" option
(4) Press the "Create" button
(5) Type "testing123" as the Site name
(6) Press the "Submit" button
(7) Select the testing123 site
(8) Click on the "Delete" button
(9) Verify the buttons

TVT00470
Reproduce:
(1) Log in
(2) Click on the "Hamburger" button and select the "Navigator" option
(3) Select the Webapp_example folder
(4) Click on the "gear" button
(5) Select the "Delete" option
(6) Verify the buttons on the dialog
Please see the attached picture for details
Comment 1 Gabriel Luong CLA 2013-07-11 01:06:57 EDT
The "Ok" and "Cancel" buttons are generated by prompt(). I am sure we can't change the default values for prompt(). I am curious if it displays differently based on the browser language.

Solution:
No fix?
Replace with our own dialog?
Comment 2 Sae Ryun Lim CLA 2013-07-11 09:56:58 EDT
(In reply to comment #1)
> The "Ok" and "Cancel" buttons are generated by prompt(). I am sure we can't
> change the default values for prompt(). I am curious if it displays
> differently based on the browser language.
> 
> Solution:
> No fix?
> Replace with our own dialog?

I just changed the language of the browser(I'm using Firefox) and Windows, and the buttons didn't display differently language
Comment 3 Ken Walker CLA 2013-07-11 12:15:11 EDT
We may have to create our own versions of these dialogs where the strings can be changed?  Anton any comments?
Comment 4 Mark Macdonald CLA 2013-07-15 17:35:33 EDT
As Gabriel said, the browser is responsible for this UI. The user has to run a localized build of their browser to see localized "OK" and "Cancel" buttons on the prompt. 

In Firefox, that means downloading a localized build from [1], or in Chrome, using "Display Chrome in this language" from the browser settings.

Merely changing the preferred language ordering for websites (which I think is what Comment 2 refers to) will not translate the browser UI.

IMO, this is a reasonable limitation because if someone is running their browser in language X, they probably understand X. 

I think there's good usability arguments for avoiding modal UI like prompt(), alert(), etc, but I wouldn't consider this an urgent an i18n bug.

[1] http://www.mozilla.org/en-US/firefox/all/
Comment 5 John Arthorne CLA 2015-05-05 14:43:32 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html