| Summary: | IES43 TVT00430 some of the strings on the UI Theme page are not externalized | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Sae Ryun Lim <srlim> | ||||||
| Component: | Client | Assignee: | Gabriel Luong <gabriel.luong> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ahunter.eclipse, gabriel.luong, ken_walker | ||||||
| Version: | 1.0 | Flags: | gabriel.luong:
review?
(mamacdon) |
||||||
| Target Milestone: | 4.0 M1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
https://github.com/gabrielluong/orion.client/commit/748e10f670776bd2a8181d76f149cb8f2f70d6ba https://github.com/gabrielluong/orion.client/commit/420be42375276150b953fda0332ca2dea11c3c85 "Show Guide", "Cancel", "Apply" and "Theme:" was externalized in 412525 Created attachment 234588 [details]
unexernalized strings marked in red circle
some strings are still not externalized, please see attachment
-Included ':' with the strings for UI Theme page in messages.js http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f818972c382bd2229bb4cb169aec3cc61fd664d3 Make sure to clear local storage. The 'Theme:' string is in ThemeBuilder.js |
Created attachment 233224 [details] UI Theme The page title "Settings", the tab "UI Theme", buttons, and labels are not externalized. Reproduce: (1) Log in (2) Click on the "Options" button (3) Select the "Settings" option (4) Select the "UI Theme" tab from the left hand side (5) Verify the strings Please see the attached picture for details