Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 412321

Summary:	[Protocol] Rename "rwt_shutdown" header
Product:	[RT] RAP	Reporter:	Ralf Sternberg <rsternberg>
Component:	RWT	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	ivan
Version:	2.2
Target Milestone:	2.2 M1
Hardware:	PC
OS:	Linux
Whiteboard:	protocol

Description Ralf Sternberg

2013-07-04 10:11:28 EDT

I'd suggest to rename this header to "shutdown" because

1. underscores are ugly
2. shutting down the UISession is not related to the widget toolkit

Comment 1 Ivan Furnadjiev

2013-07-07 13:50:11 EDT

The "rwt_" prefix was introduced to correspond to "rwt_initialize" parameter. I agree with Ralf to rename it to "shutdown". In addition I'll propose to rename "rwt_initialize" parameter to "startup".

Comment 2 Ralf Sternberg

2013-07-08 06:37:18 EDT

> rename "rwt_initialize" parameter to "startup"

I'd agree to this renaming but I still wonder if we could get rid of this parameter entirely and discover the startup case by the missing request counter instead. Once we change the request counter to be incremented on the client, it would be "requestsCounter": 0.

Comment 3 Ralf Sternberg

2013-07-08 06:40:09 EDT

What about sending a display destroy operation instead of the "shutdown" header?

Comment 4 Ivan Furnadjiev

2013-07-08 06:55:27 EDT

(In reply to comment #3)
> What about sending a display destroy operation instead of the "shutdown"
> header?
For me this will make the things a little bit messy as such destroy operation will not be handled by corresponding LCA (DisplayLCA), but by LifeCycleServiceHandler (in case of shutdown the life cycle is not executed).

Comment 5 Ralf Sternberg

2013-07-09 05:29:34 EDT

(In reply to comment #4)
> (In reply to comment #3)
> > What about sending a display destroy operation instead of the "shutdown"
> > header?
> For me this will make the things a little bit messy as such destroy
> operation will not be handled by corresponding LCA (DisplayLCA), but by
> LifeCycleServiceHandler (in case of shutdown the life cycle is not executed).

Agree. So let's rename it to "shutdown".

As for the rwt_initialize header, we agreed to remove it later as part of bug 403653.

Comment 6 Ivan Furnadjiev

2013-07-19 08:44:06 EDT

Fixed in master with commit 78520251b0ac904c157b9324256bbb1488f1e6dd.