Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 411788

Summary: [BrowserCompatibility] Alert not displayed on minified orion in <IE10 - undo converting BrowserCompatibility into a module
Product: [ECD] Orion Reporter: Gabriel Luong <gabriel.luong>
Component: ClientAssignee: Gabriel Luong <gabriel.luong>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: 3.0Flags: mamacdon: review+
Target Milestone: 4.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Gabriel Luong CLA 2013-06-27 11:28:05 EDT 
Currently, debugging the built script in IE8 shows that it errors on Object.defineProperty. It seems to be parse the built-X.js and detects these properties that it does not support before executing the code. However, it will halt any execution of the code when it detects an error. If I keep 'continuing' in the IE8 debugger past these errors, I will eventually see the alert.

Mark found that it might be because of the order the scripts are loaded
http://requirejs.org/docs/1.0/docs/api.html#order
Comment 1 Mark Macdonald CLA 2013-06-27 11:53:58 EDT 
Darn, this happened because I nagged Gabriel into converting browserCompatibility into a module (bug 408762). It needs to execute as early as possible, we can't rely on the AMD loader to run it at some indeterminate time, otherwise URL-shim (which uses Object.defineProperties) will execute first, and blow up before the alert can be displayed.