Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 411598

Summary:	Editor commands fail to process statuses from delegated UIs
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Editor	Assignee:	Simon Kaegi <simon_kaegi>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	mamacdon, simon_kaegi
Version:	3.0	Flags:	simon_kaegi: review+ mamacdon: review+
Target Milestone:	3.0 RC3
Hardware:	All
OS:	All
Whiteboard:

Description Szymon Brandys

2013-06-25 09:06:31 EDT

It fails with:

ReferenceError: serviceRegistry is not defined
http://localhost:8088/orion/editorCommands.js
Line 321

Comment 1 Szymon Brandys

2013-06-25 09:07:26 EDT

The fix is to change:
var statusService = serviceRegistry.getService("orion.page.message");
to
var statusService = self.serviceRegistry.getService("orion.page.message");
in line 321

Comment 2 Szymon Brandys

2013-06-25 09:18:24 EDT

I would push it to 3.0, but I will do whatever Simon decides.

Comment 3 Szymon Brandys

2013-06-25 09:19:02 EDT

Actually it is a blocker for some...

Comment 4 Mark Macdonald

2013-06-25 09:55:33 EDT

Wow. So someone actually was using the serviceRegistry as a global.

Comment 5 Simon Kaegi

2013-06-25 10:26:09 EDT

I unfortunately think this needs to be fixed.

Comment 6 Szymon Brandys

2013-06-25 10:34:07 EDT

This is the commit to review:
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=411598&id=298a61c13028618de2f72fa50c39090d2b8fb0b2

Comment 7 Simon Kaegi

2013-06-25 10:47:29 EDT

Thanks Szymon, I pushed with tweaks to get a clean jslint file.
--
https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2d732cfb66ce150c83d90c804f2fcabce3134ec4